# Re: \[PATCH v4 10/20\] drm/bridge: inno-hdmi: Add .mode\_valid platform operation

- From: sashiko-bot@kernel.org
- Date: 2026-09-15 15:37:09 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2026/09/17580585
- Thread: https://ratatoskr.run/linux-clk/2026/09/17580529/t.md

```text
> inno_hdmi_bridge_mode_valid() validates the pixel clock against
> hdmi->refclk, but that clock is optional and is only present on
> platforms that describe a "ref" clock. Platforms where the pixel clock
> is produced by a separate device - such as the StarFive JH7110, whose
> PHY is both the clock and the PHY provider - have no "ref" clock, so
> the check is skipped entirely and every mode is reported as valid.
> 
> A mode the platform cannot generate is then advertised to userspace.
> The subsequent modeset appears to succeed, since the atomic enable path
> cannot fail, and the display silently stays blank.
> 
> Add a .mode_valid platform operation so platforms can reject modes they
> are unable to drive. Platforms that do not implement it are unaffected.
> 
> Reviewed-by: Joshua Peisach <redacted>
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com?part=10

```