# Re: \[PATCH v3 11/19\] soc: starfive: Add jh7110-hdmi-subsystem driver

- From: Michal Wilczynski \<m.wilczynski@samsung.com\>
- Date: 2026-09-14 21:46:10 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2026/09/17575875
- Thread: https://ratatoskr.run/linux-phy/2026/09/17514319/t.md

```text


On 9/7/26 10:23, Uwe Kleine-König wrote:
> Hello Michael,
> 
> On Fri, Sep 04, 2026 at 03:27:12PM +0200, Michal Wilczynski wrote:
>> +#include <linux/mod_devicetable.h>
>> [...]
>> +#include <linux/platform_device.h>
> 
> Please don't add includes for <linux/mod_devicetable.h> as it introduces
> many unneeded build dependencies. Either rely on
> <linux/platform_device.h> providing of_device_id (IMHO preferred), or
> include <linux/device-id/of.h> directly.
> 
> The same applies to two more patches in this series.
> 
> Best regards
> Uwe

Thank you for your review. This will be fixed for v4.

Best regards,
-- 
Michal Wilczynski [ref]
```