# Re: \[PATCH v2 08/11\] ASoC: SDCA: make find\_sdca\_control\_reset() return void

- From: Charles Keepax \<ckeepax@opensource.cirrus.com\>
- Date: 2026-09-07 13:04:31 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2026/09/17525418
- Thread: https://ratatoskr.run/linux-sound/2026/09/17523622/t.md

```text
On Mon, Sep 07, 2026 at 01:32:30PM +0200, Pierre-Louis Bossart wrote:
> On 9/7/26 10:37, Srinivas Kandagatla wrote:
> > find_sdca_control_reset() only ever returns 0 -- it just sets
> > control->has_reset / control->reset for the framework-known
> > (entity type, control selector) mappings.  The int return + caller
> > error check in find_sdca_entity_control() are dead code.
> > 
> > Convert to void and drop the check.  No functional change.
> > 
> > Signed-off-by: Srinivas Kandagatla <redacted>
> 
> That looks also unrelated to DT stuff, not sure it belongs here as patch
> 08/11
> 
> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>

Agree lets pull these two patches out and submit seperately as we
can merge them both happily today.

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles
```