Qualcomm SM7250 SoC is known as lito.
This patchset add SM7250 SoC ID.
Sreeshankar K (2):
soc: qcom: socinfo: Add SM7250 SoC ID
dt-bindings: arm: qcom,ids: Add SoC ID for SM7250
drivers/soc/qcom/socinfo.c | 1 +
include/dt-bindings/arm/qcom,ids.h | 1 +
2 files changed, 2 insertions(+)
--
2.43.0
Add SoC ID for Qualcomm SM7250 SoC.
Signed-off-by: Sreeshankar K <redacted>
---
drivers/soc/qcom/socinfo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index af418adad..54b1f8e1b 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -449,6 +449,7 @@ static const struct soc_id soc_id[] = {
{ qcom_board_id(IPQ8172) },
{ qcom_board_id(IPQ8173) },
{ qcom_board_id(IPQ8174) },
+ { qcom_board_id(SM7250) },
{ qcom_board_id(IPQ6018) },
{ qcom_board_id(IPQ6028) },
{ qcom_board_id(SDM429W) },--
2.43.0
Add the ID for the Qualcomm SM7250 SoC.
Signed-off-by: Sreeshankar K <redacted>
---
include/dt-bindings/arm/qcom,ids.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index 1af73c0ad..3c1ba5168 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -208,6 +208,7 @@
#define QCOM_ID_IPQ8172 397
#define QCOM_ID_IPQ8173 398
#define QCOM_ID_IPQ8174 399
+#define QCOM_ID_SM7250 400
#define QCOM_ID_IPQ6018 402
#define QCOM_ID_IPQ6028 403
#define QCOM_ID_SDM429W 416
--
2.43.0
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit introduces a compilation failure because the macro `QCOM_ID_SM7250` is undeclared. The macro `qcom_board_id(SM7250)` expands to `QCOM_ID_SM7250`, which is not defined in `include/dt-bindings/arm/qcom,ids.h` or anywhere else in the tree.
--
--- Patch [1]: [PATCH 1/2] soc: qcom: socinfo: Add SM7250 SoC ID ---
commit 8ca1fecd3b445847ec519f60e57b6e9de9904c54
Author: Sreeshankar K [off-list ref]
soc: qcom: socinfo: Add SM7250 SoC ID
This commit adds the SoC ID for the Qualcomm SM7250 SoC to the socinfo driver.
quoted hunk
diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index af418adad7aaf..54b1f8e1b9359 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -449,6 +449,7 @@ static const struct soc_id soc_id[] = {
{ qcom_board_id(IPQ8172) },
{ qcom_board_id(IPQ8173) },
{ qcom_board_id(IPQ8174) },
+ { qcom_board_id(SM7250) },
[Severity: Low]
Does this cause a compilation failure? The qcom_board_id(SM7250) macro
expands to QCOM_ID_SM7250, but it appears that QCOM_ID_SM7250 is not defined
in include/dt-bindings/arm/qcom,ids.h or anywhere else in the tree.
{ qcom_board_id(IPQ6018) },
{ qcom_board_id(IPQ6028) },
{ qcom_board_id(SDM429W) },
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260816081213.5495-1-sreeshankar0910@gmail.com?part=1
On 8/16/26 10:12 AM, Sreeshankar K wrote:
Add the ID for the Qualcomm SM7250 SoC.
Signed-off-by: Sreeshankar K <redacted>
---
Reviewed-by: Konrad Dybcio <redacted>
Konrad