[PATCH] of: reserved_mem: Add missing IORESOURCE_MEM flag on resources

Subsystems: open firmware and flattened device tree, the rest

STALE427d LANDED

Landed in mainline as aea70964b5a7 on 2025-08-21.

3 messages, 3 authors, 2025-08-21 · open the first message on its own page

[PATCH] of: reserved_mem: Add missing IORESOURCE_MEM flag on resources

From: "Rob Herring (Arm)" <robh@kernel.org>
Date: 2025-08-20 19:29:09

Commit f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse
"memory-region"') failed to set IORESOURCE_MEM flag on the resources.
The result is functions such as devm_ioremap_resource_wc() will fail.
Add the missing flag.

Fixes: f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse "memory-region"')
Reported-by: Iuliana Prodan <redacted>
Reported-by: Daniel Baluta <redacted>
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 drivers/of/of_reserved_mem.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
index 77016c0cc296..d3b7c4ae429c 100644
--- a/drivers/of/of_reserved_mem.c
+++ b/drivers/of/of_reserved_mem.c
@@ -771,6 +771,7 @@ int of_reserved_mem_region_to_resource(const struct device_node *np,
 		return -EINVAL;
 
 	resource_set_range(res, rmem->base, rmem->size);
+	res->flags = IORESOURCE_MEM;
 	res->name = rmem->name;
 	return 0;
 }
-- 
2.50.1

Re: [PATCH] of: reserved_mem: Add missing IORESOURCE_MEM flag on resources

From: Saravana Kannan <hidden>
Date: 2025-08-20 20:51:45

On Wed, Aug 20, 2025 at 12:29 PM Rob Herring (Arm) [off-list ref] wrote:
Commit f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse
"memory-region"') failed to set IORESOURCE_MEM flag on the resources.
The result is functions such as devm_ioremap_resource_wc() will fail.
Add the missing flag.

Fixes: f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse "memory-region"')
Reported-by: Iuliana Prodan <redacted>
Reported-by: Daniel Baluta <redacted>
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Saravana Kannan <redacted>

-Saravana
quoted hunk
---
 drivers/of/of_reserved_mem.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
index 77016c0cc296..d3b7c4ae429c 100644
--- a/drivers/of/of_reserved_mem.c
+++ b/drivers/of/of_reserved_mem.c
@@ -771,6 +771,7 @@ int of_reserved_mem_region_to_resource(const struct device_node *np,
                return -EINVAL;

        resource_set_range(res, rmem->base, rmem->size);
+       res->flags = IORESOURCE_MEM;
        res->name = rmem->name;
        return 0;
 }
--
2.50.1

Re: [PATCH] of: reserved_mem: Add missing IORESOURCE_MEM flag on resources

From: Iuliana Prodan <hidden>
Date: 2025-08-21 06:39:49

On 8/20/2025 10:28 PM, Rob Herring (Arm) wrote:
Commit f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse
"memory-region"') failed to set IORESOURCE_MEM flag on the resources.
The result is functions such as devm_ioremap_resource_wc() will fail.
Add the missing flag.

Fixes: f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse "memory-region"')
Reported-by: Iuliana Prodan <redacted>
Reported-by: Daniel Baluta <redacted>
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Tested-by: Iuliana Prodan <redacted>
Reviewed-by: Iuliana Prodan <redacted>

Thanks,
Iulia
quoted hunk
---
  drivers/of/of_reserved_mem.c | 1 +
  1 file changed, 1 insertion(+)
diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
index 77016c0cc296..d3b7c4ae429c 100644
--- a/drivers/of/of_reserved_mem.c
+++ b/drivers/of/of_reserved_mem.c
@@ -771,6 +771,7 @@ int of_reserved_mem_region_to_resource(const struct device_node *np,
  		return -EINVAL;
  
  	resource_set_range(res, rmem->base, rmem->size);
+	res->flags = IORESOURCE_MEM;
  	res->name = rmem->name;
  	return 0;
  }

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help