This series introduces the changes needed for trivial spi
based sensors from ABB, currently operated from userspace.
The last patch adds the spidevices to the DTS files, already
in mainline.
make dtbs_check showed no errors/warnings for the dts files
DTC [C] arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-adpismarc.dtb
DTC [C] arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-helios.dtb
DTC arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-helios-lvds.dtbo
DTC [C] arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-proton2s.dtb
Heiko Schocher (3):
dt-bindings: trivial-devices: Document ABB sensors
spi: spidev: Add an entry for the ABB spi sensors
arm64: dts: imx8mp: add ABB spi sensors
.../devicetree/bindings/trivial-devices.yaml | 2 ++
.../freescale/imx8mp-aristainetos3-helios.dts | 28 +++++++++++++++++++
.../imx8mp-aristainetos3-proton2s.dts | 22 +++++++++++++++
drivers/spi/spidev.c | 2 ++
4 files changed, 54 insertions(+)
--
2.20.1
base-commit: 3668990919df7a8df60ab1f39ec95f59434b68ec
add for the spi busses the ABB sensor trivial compatible
entry, so they can be accessed from userspace.
Signed-off-by: Heiko Schocher <redacted>
---
.../freescale/imx8mp-aristainetos3-helios.dts | 28 +++++++++++++++++++
.../imx8mp-aristainetos3-proton2s.dts | 22 +++++++++++++++
2 files changed, 50 insertions(+)
Add documentation for spi based ABB sensors, which are
currently operated from userspace.
Signed-off-by: Heiko Schocher <redacted>
---
Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
1 file changed, 2 insertions(+)
@@ -30,6 +30,8 @@ properties:items:# Entries are sorted alphanumerically by the compatible-enum:+# ABB register based spi sensors+-abb,spi-sensor# Acbel fsg032 power supply-acbel,fsg032# SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin
@@ -30,6 +30,8 @@ properties:items:# Entries are sorted alphanumerically by the compatible-enum:+# ABB register based spi sensors+-abb,spi-sensor# Acbel fsg032 power supply-acbel,fsg032# SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin
@@ -30,6 +30,8 @@ properties:items:# Entries are sorted alphanumerically by the compatible-enum:+# ABB register based spi sensors+-abb,spi-sensor# Acbel fsg032 power supply-acbel,fsg032# SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin
Hi Guenther, Rob,
On 20.07.25 05:25, Guenter Roeck wrote:
On 7/19/25 19:11, Rob Herring wrote:
quoted
On Sat, Jul 19, 2025 at 08:33:52AM +0200, Heiko Schocher wrote:
quoted
Add documentation for spi based ABB sensors, which are
currently operated from userspace.
What is userspace? That has nothing to do with bindings.
Taking one step further back ... what are "spi based ABB sensors" ?
Guenter
quoted
Please provide some details about this h/w and convince me it is
trivial.
This sensors are fully controlled through spidev driver, with a simple
register based interface and they have no other connections as the SPI
lines, so they only need a compatible entry.
bye,
Heiko
items:
# Entries are sorted alphanumerically by the compatible
- enum:
+ # ABB register based spi sensors
+ - abb,spi-sensor
# Acbel fsg032 power supply
- acbel,fsg032
# SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin
--
2.20.1
From: Mark Brown <broonie@kernel.org> Date: 2025-07-21 15:56:15
On Sat, 19 Jul 2025 08:33:51 +0200, Heiko Schocher wrote:
This series introduces the changes needed for trivial spi
based sensors from ABB, currently operated from userspace.
The last patch adds the spidevices to the DTS files, already
in mainline.
make dtbs_check showed no errors/warnings for the dts files
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/3] dt-bindings: trivial-devices: Document ABB sensors
commit: aad2f87cbcab56b322109d26d7b11842a09df91f
[2/3] spi: spidev: Add an entry for the ABB spi sensors
commit: d60f7cab7c04944a79af16caa43c141e780a59c6
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From: Krzysztof Kozlowski <krzk@kernel.org> Date: 2025-07-21 16:25:02
On 21/07/2025 17:56, Mark Brown wrote:
On Sat, 19 Jul 2025 08:33:51 +0200, Heiko Schocher wrote:
quoted
This series introduces the changes needed for trivial spi
based sensors from ABB, currently operated from userspace.
The last patch adds the spidevices to the DTS files, already
in mainline.
make dtbs_check showed no errors/warnings for the dts files
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/3] dt-bindings: trivial-devices: Document ABB sensors
commit: aad2f87cbcab56b322109d26d7b11842a09df91f
[2/3] spi: spidev: Add an entry for the ABB spi sensors
commit: d60f7cab7c04944a79af16caa43c141e780a59c6
That's unexpected, Mark. Patches received two objections/comments and I
don't think discussion was resolved.
ABB is huge company, probably making hundreds or more of sensors. The
patchset basically claims that all of them work with spidev. It does not
providing any model names or details, so it seems really incomplete to
call them trivial devices.
Best regards,
Krzysztof
Hello Krzysztof,
On 21.07.25 18:24, Krzysztof Kozlowski wrote:
On 21/07/2025 17:56, Mark Brown wrote:
quoted
On Sat, 19 Jul 2025 08:33:51 +0200, Heiko Schocher wrote:
quoted
This series introduces the changes needed for trivial spi
based sensors from ABB, currently operated from userspace.
The last patch adds the spidevices to the DTS files, already
in mainline.
make dtbs_check showed no errors/warnings for the dts files
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/3] dt-bindings: trivial-devices: Document ABB sensors
commit: aad2f87cbcab56b322109d26d7b11842a09df91f
[2/3] spi: spidev: Add an entry for the ABB spi sensors
commit: d60f7cab7c04944a79af16caa43c141e780a59c6
That's unexpected, Mark. Patches received two objections/comments and I
don't think discussion was resolved.
ABB is huge company, probably making hundreds or more of sensors. The
patchset basically claims that all of them work with spidev. It does not
providing any model names or details, so it seems really incomplete to
call them trivial devices.
I do not know how many different sensors they have, nor if that department can
speak for the whole company...
What I have as information is:
https://lore.kernel.org/linux-spi/2477dc64-92a0-9dc9-d168-56646d0d796e@denx.de/
and I get no more information about them currently. May I should
add some sort of trivial into compatible name? Something like
"abb,spi-trivial-sensor"
or
"abb,spidev-trivial-sensor"
which makes it clearer, that only ABB trivial sensor, controlled through spidev
driver, is connected here?
Looking into definiton of "trivial devices" in
Documentation/devicetree/bindings/trivial-devices.yaml
"""
description: |
This is a list of trivial I2C and SPI devices that have simple device tree
bindings, consisting only of a compatible field, an address and possibly an
interrupt line.
"""
which fits exactly, as they even have nothing more than the SPI lines
connected to the carrier board(s).
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Johanna Denk, Tabea Lutz
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de
Hello Krzysztof,
On 21.07.25 18:24, Krzysztof Kozlowski wrote:
quoted
On 21/07/2025 17:56, Mark Brown wrote:
quoted
On Sat, 19 Jul 2025 08:33:51 +0200, Heiko Schocher wrote:
quoted
This series introduces the changes needed for trivial spi
based sensors from ABB, currently operated from userspace.
The last patch adds the spidevices to the DTS files, already
in mainline.
make dtbs_check showed no errors/warnings for the dts files
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/3] dt-bindings: trivial-devices: Document ABB sensors
commit: aad2f87cbcab56b322109d26d7b11842a09df91f
[2/3] spi: spidev: Add an entry for the ABB spi sensors
commit: d60f7cab7c04944a79af16caa43c141e780a59c6
That's unexpected, Mark. Patches received two objections/comments and I
don't think discussion was resolved.
ABB is huge company, probably making hundreds or more of sensors. The
patchset basically claims that all of them work with spidev. It does not
providing any model names or details, so it seems really incomplete to
call them trivial devices.
I do not know how many different sensors they have, nor if that department can
speak for the whole company...
What I have as information is:
https://lore.kernel.org/linux-spi/2477dc64-92a0-9dc9-d168-56646d0d796e@denx.de/
and I get no more information about them currently. May I should
add some sort of trivial into compatible name? Something like
"abb,spi-trivial-sensor"
or
"abb,spidev-trivial-sensor"
which makes it clearer, that only ABB trivial sensor, controlled through spidev
driver, is connected here?
FWIW, I always thought that devicetree is not supposed to contain such generic
information. Is it even appropriate to list something like this in devicetree
in the first place ?
If so, what prevents anyone from submitting hundreds of
"<company>,spidev-trivial-<device-type>" entries, using the same line of argument ?
Guenter
Hello Krzysztof,
On 21.07.25 18:24, Krzysztof Kozlowski wrote:
quoted
On 21/07/2025 17:56, Mark Brown wrote:
quoted
On Sat, 19 Jul 2025 08:33:51 +0200, Heiko Schocher wrote:
quoted
This series introduces the changes needed for trivial spi
based sensors from ABB, currently operated from userspace.
The last patch adds the spidevices to the DTS files, already
in mainline.
make dtbs_check showed no errors/warnings for the dts files
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/3] dt-bindings: trivial-devices: Document ABB sensors
commit: aad2f87cbcab56b322109d26d7b11842a09df91f
[2/3] spi: spidev: Add an entry for the ABB spi sensors
commit: d60f7cab7c04944a79af16caa43c141e780a59c6
That's unexpected, Mark. Patches received two objections/comments and I
don't think discussion was resolved.
ABB is huge company, probably making hundreds or more of sensors. The
patchset basically claims that all of them work with spidev. It does not
providing any model names or details, so it seems really incomplete to
call them trivial devices.
I do not know how many different sensors they have, nor if that department can
speak for the whole company...
What I have as information is:
https://lore.kernel.org/linux-spi/2477dc64-92a0-9dc9-d168-56646d0d796e@denx.de/
and I get no more information about them currently. May I should
add some sort of trivial into compatible name? Something like
"abb,spi-trivial-sensor"
or
"abb,spidev-trivial-sensor"
which makes it clearer, that only ABB trivial sensor, controlled through spidev
driver, is connected here?
FWIW, I always thought that devicetree is not supposed to contain such generic
information. Is it even appropriate to list something like this in devicetree
in the first place ?
If so, what prevents anyone from submitting hundreds of
"<company>,spidev-trivial-<device-type>" entries, using the same line of argument ?
Agreed. These should have separate compatibles based on what any OS etc
might want to bind to them. Just because their model in Linux is spidev etc
that shouldn't mean a generic ID is appropriate.
Can we at least have some examples to motivate the discussion?
Jonathan
From: Krzysztof Kozlowski <krzk@kernel.org> Date: 2025-07-22 11:07:47
On 22/07/2025 06:05, Heiko Schocher wrote:
Hello Krzysztof,
On 21.07.25 18:24, Krzysztof Kozlowski wrote:
quoted
On 21/07/2025 17:56, Mark Brown wrote:
quoted
On Sat, 19 Jul 2025 08:33:51 +0200, Heiko Schocher wrote:
quoted
This series introduces the changes needed for trivial spi
based sensors from ABB, currently operated from userspace.
The last patch adds the spidevices to the DTS files, already
in mainline.
make dtbs_check showed no errors/warnings for the dts files
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/3] dt-bindings: trivial-devices: Document ABB sensors
commit: aad2f87cbcab56b322109d26d7b11842a09df91f
[2/3] spi: spidev: Add an entry for the ABB spi sensors
commit: d60f7cab7c04944a79af16caa43c141e780a59c6
That's unexpected, Mark. Patches received two objections/comments and I
don't think discussion was resolved.
ABB is huge company, probably making hundreds or more of sensors. The
patchset basically claims that all of them work with spidev. It does not
providing any model names or details, so it seems really incomplete to
call them trivial devices.
I do not know how many different sensors they have, nor if that department can
speak for the whole company...
Considering how big company is, they could have 1 or 1000 sensors.
which makes it clearer, that only ABB trivial sensor, controlled through spidev
driver, is connected here?
No, what is trivial? Which one is trivial and which one is not? How one
judges that one sensor should go here and other should not?
Best regards,
Krzysztof
Hello Krzysztof,
On 21.07.25 18:24, Krzysztof Kozlowski wrote:
quoted
On 21/07/2025 17:56, Mark Brown wrote:
quoted
On Sat, 19 Jul 2025 08:33:51 +0200, Heiko Schocher wrote:
quoted
This series introduces the changes needed for trivial spi
based sensors from ABB, currently operated from userspace.
The last patch adds the spidevices to the DTS files, already
in mainline.
make dtbs_check showed no errors/warnings for the dts files
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/3] dt-bindings: trivial-devices: Document ABB sensors
commit: aad2f87cbcab56b322109d26d7b11842a09df91f
[2/3] spi: spidev: Add an entry for the ABB spi sensors
commit: d60f7cab7c04944a79af16caa43c141e780a59c6
That's unexpected, Mark. Patches received two objections/comments and I
don't think discussion was resolved.
ABB is huge company, probably making hundreds or more of sensors. The
patchset basically claims that all of them work with spidev. It does not
providing any model names or details, so it seems really incomplete to
call them trivial devices.
I do not know how many different sensors they have, nor if that department can
speak for the whole company...
What I have as information is:
https://lore.kernel.org/linux-spi/2477dc64-92a0-9dc9-d168-56646d0d796e@denx.de/
and I get no more information about them currently. May I should
add some sort of trivial into compatible name? Something like
"abb,spi-trivial-sensor"
or
"abb,spidev-trivial-sensor"
which makes it clearer, that only ABB trivial sensor, controlled through spidev
driver, is connected here?
FWIW, I always thought that devicetree is not supposed to contain such generic
information. Is it even appropriate to list something like this in devicetree
in the first place ?
If so, what prevents anyone from submitting hundreds of
"<company>,spidev-trivial-<device-type>" entries, using the same line of argument ?
Agreed. These should have separate compatibles based on what any OS etc
might want to bind to them. Just because their model in Linux is spidev etc
that shouldn't mean a generic ID is appropriate.
Can we at least have some examples to motivate the discussion?
I am sorry, I get no more information about the sensors... even I do
not know the count of variants. What I can say is, that this sensors
measure gases, and are only used "internal" on the aristainetos3 carriers.
So a proposal would be:
# ABB gas sensor on aristainetos3 carriers
compatible "abb,aristainetos-gas-sensor"
bye,
Heiko