# Re: \[PATCH v4 2/5\] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support

- From: George Moussalem \<hidden\>
- Date: 2025-06-09 12:39:12 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2025/06/3083381
- Thread: https://ratatoskr.run/netdev/2025/06/3083294/t.md

```text


On 6/9/25 16:30, Andrew Lunn wrote:
> On Mon, Jun 09, 2025 at 04:20:12PM +0400, George Moussalem wrote:
>>
>>
>> On 6/9/25 16:16, Andrew Lunn wrote:
>>>> +  - |
>>>> +    #include <dt-bindings/reset/qcom,gcc-ipq5018.h>
>>>> +
>>>> +    mdio {
>>>> +        #address-cells = <1>;
>>>> +        #size-cells = <0>;
>>>> +
>>>> +        /* add alias to set qcom,dac-preset-short-cable on boards that need it */
>>>> +        ge_phy: ethernet-phy@7 {
>>>> +            compatible = "ethernet-phy-id004d.d0c0";
>>>> +            reg = <7>;
>>>> +
>>>> +            resets = <&gcc GCC_GEPHY_MISC_ARES>;
>>>
>>> What do you mean by 'alias' here?
>>
>> I mean node label. Since it was asked whether it's needed, I added a comment
>> to say why, so that boards can reference it to set the
>> qcom,dac-preset-short-cable property in the DTS as needed.
>
> Ah, O.K.
>
> Since this is internal, it is in the SoC .dtsi file. A board would
> need to add the property in its .dts file, and so need a label.
>
> The example itself does not need it, but the real version does. If it
> was one of the DT Maintainers who asked for it, then O.K.

Konrad recommended to drop the label unless it was used/passed somewhere. So I added this comment to explain for future reference. If not needed, I'll remove it for v5.

Link: https://lore.kernel.org/all/f2732e5a-7ba9-4ed3-8d33-bd2b996f9a1d@oss.qualcomm.com/

>
> 	Andrew

George
```
