On Tue, 13 May 2025, Mathieu Dubois-Briand wrote:

On Mon May 12, 2025 at 11:21 AM CEST, Andy Shevchenko wrote:

quoted

On Fri, May 09, 2025 at 11:14:36AM +0200, mathieu.dubois-briand@bootlin.com wrote:

quoted

+#define MAX7360_REG_GPIO_LAST		0x5F

quoted

+#define MAX7360_FIFO_EMPTY		0x3f
+#define MAX7360_FIFO_OVERFLOW		0x7f

Please, be consistent in style of the values.

Is your point about the alignment of the values? Most of these are
aligned on column 41, including the ones above. I just have an exception
with MAX7360_PORT_CFG_*, as they are a bit too long. But as we are using
tabs here, indentation appears a bit broken in the patch.

I believe the point was in reference to capitalisation.

-- 
Lee Jones [李琼斯]