[PATCH] ARM: dts: BCM5301X: correct rx-internal-delay-ps & enable flow control on extsw on Asus RT-AC88U

Subsystems: the rest

STALE1706d

2 messages, 2 authors, 2021-12-19 · open the first message on its own page

[PATCH] ARM: dts: BCM5301X: correct rx-internal-delay-ps & enable flow control on extsw on Asus RT-AC88U

From: Arınç ÜNAL <hidden>
Date: 2021-12-16 16:19:49

The current rx-internal-delay-ps value on the Realtek switch node, 2000,
will be divided by 300, resulting in 6.66, which will be rounded to the
closest step value, 7. Change it to 2100 anyway to be accurate.

Commit ef136837aaf6 ("net: dsa: rtl8365mb: set RGMII RX delay in steps of
0.3 ns")

Flow control needs to be enabled on both sides. It's already enabled on the
CPU port of the Realtek switch. Enable it on the extsw port of the Broadcom
switch as well.

Signed-off-by: Arınç ÜNAL <redacted>
---
 arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts b/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts
index 16dea851719f..df8199fd4eb4 100644
--- a/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts
+++ b/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts
@@ -138,7 +138,7 @@ port@6 {
 				ethernet = <&sw0_p5>;
 				phy-mode = "rgmii";
 				tx-internal-delay-ps = <2000>;
-				rx-internal-delay-ps = <2000>;
+				rx-internal-delay-ps = <2100>;
 
 				fixed-link {
 					speed = <1000>;
@@ -213,6 +213,7 @@ sw0_p5: port@5 {
 			fixed-link {
 				speed = <1000>;
 				full-duplex;
+				pause;
 			};
 		};
 
-- 
2.25.1

Re: [PATCH] ARM: dts: BCM5301X: correct rx-internal-delay-ps & enable flow control on extsw on Asus RT-AC88U

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-12-19 19:36:56

On Fri, 17 Dec 2021 00:03:19 +0800, Arınç ÜNAL [off-list ref] wrote:
The current rx-internal-delay-ps value on the Realtek switch node, 2000,
will be divided by 300, resulting in 6.66, which will be rounded to the
closest step value, 7. Change it to 2100 anyway to be accurate.

Commit ef136837aaf6 ("net: dsa: rtl8365mb: set RGMII RX delay in steps of
0.3 ns")

Flow control needs to be enabled on both sides. It's already enabled on the
CPU port of the Realtek switch. Enable it on the extsw port of the Broadcom
switch as well.

Signed-off-by: Arınç ÜNAL <redacted>
---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help