[PATCH] dt-bindings: pwm: Avoid selecting schema on node name match

Subsystems: open firmware and flattened device tree bindings, pwm subsystem, the rest

STALE1712d

2 messages, 2 authors, 2021-12-08 · open the first message on its own page

[PATCH] dt-bindings: pwm: Avoid selecting schema on node name match

From: Thierry Reding <hidden>
Date: 2021-12-07 12:49:06

From: Thierry Reding <redacted>

Currently any node whose name starts with the "pwm-" prefix will match
this schema and in turn required the "#pwm-cells" property. Avoid this
by marking the schema with select: false, therefore only activating the
schema when directly included from a PWM controller schema file.

Signed-off-by: Thierry Reding <redacted>
---
Rob,

I've seen this used in some other schema files, but wanted to
double-check with you if this is the correct solution for this problem.

Thanks,
Thierry

 Documentation/devicetree/bindings/pwm/pwm.yaml | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml
index 2effe6c0de6b..3c01f85029e5 100644
--- a/Documentation/devicetree/bindings/pwm/pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
@@ -9,6 +9,8 @@ title: PWM controllers (providers)
 maintainers:
   - Thierry Reding <thierry.reding@gmail.com>
 
+select: false
+
 properties:
   $nodename:
     pattern: "^pwm(@.*|-[0-9a-f])*$"
-- 
2.33.1

Re: [PATCH] dt-bindings: pwm: Avoid selecting schema on node name match

From: Rob Herring <robh@kernel.org>
Date: 2021-12-08 18:48:39

On Tue, Dec 07, 2021 at 01:48:55PM +0100, Thierry Reding wrote:
From: Thierry Reding <redacted>

Currently any node whose name starts with the "pwm-" prefix will match
this schema and in turn required the "#pwm-cells" property. Avoid this
by marking the schema with select: false, therefore only activating the
schema when directly included from a PWM controller schema file.
Pinctrl nodes? I'd rather change pin node names.
Signed-off-by: Thierry Reding <redacted>
---
Rob,

I've seen this used in some other schema files, but wanted to
double-check with you if this is the correct solution for this problem.
I suppose this is fine. This schema is just about pointless as each 
producer has to define #pwm-cells anyways.

Acked-by: Rob Herring <robh@kernel.org>
quoted hunk
Thanks,
Thierry

 Documentation/devicetree/bindings/pwm/pwm.yaml | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml
index 2effe6c0de6b..3c01f85029e5 100644
--- a/Documentation/devicetree/bindings/pwm/pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
@@ -9,6 +9,8 @@ title: PWM controllers (providers)
 maintainers:
   - Thierry Reding <thierry.reding@gmail.com>
 
+select: false
+
 properties:
   $nodename:
     pattern: "^pwm(@.*|-[0-9a-f])*$"
-- 
2.33.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help