From: Marc Zyngier <maz@kernel.org>
Sent: Thursday, December 16, 2021 4:52 PM
To: qinjian[覃健] <qinjian@cqplus1.com>
Cc: robh+dt@kernel.org; mturquette@baylibre.com; sboyd@kernel.org; tglx@linutronix.de; p.zabel@pengutronix.de;
linux@armlinux.org.uk; broonie@kernel.org; arnd@arndb.de; stefan.wahren@i2se.com; linux-arm-kernel@lists.infradead.org;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org; Wells Lu 呂芳騰 [off-list ref]
Subject: Re: [PATCH v6 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver

On Thu, 16 Dec 2021 07:08:10 +0000,
Qin Jian [off-list ref] wrote:

quoted

Add interrupt controller driver for Sunplus SP7021 SoC.

This is the interrupt controller in P-chip which collects all interrupt
sources in P-chip and routes them to parent interrupt controller in C-chip.

Signed-off-by: Qin Jian <qinjian@cqplus1.com>
---
Fix the comments from Marc.

No, you didn't.

quoted

+void sp_intc_set_ext(u32 hwirq, int ext_num)
+{
+	sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num);
+}
+EXPORT_SYMBOL_GPL(sp_intc_set_ext);

I already commented on this. In case it wasn't clear, this is a strong
NAK to random low-level hacks like this.

Yes, I just forgot delete this.
Sorry for my mistake, I'll fix it on next commit.