Re: [PATCH v3 2/3] dt-bindings: mmc: Add bindings for LiteSDCard
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-12-09 08:38:24
Also in:
linux-mmc, lkml
Hi Gabriel, On Thu, Dec 9, 2021 at 2:08 AM Gabriel L. Somlo [off-list ref] wrote:
... which took care of the bulk of the error messages reported. However,
I'm still getting the one below, whether or not I leave the `maxItems 1`
line there under `clocks:`
$ make ARCH=riscv CROSS_COMPILE=riscv64-unknown-linux-gnu- dt_binding_check
LINT Documentation/devicetree/bindings
CHKDT Documentation/devicetree/bindings/processed-schema-examples.json
/home/somlo/linux/Documentation/devicetree/bindings/clock/litex,clock.yaml: properties:clock-output-names: {'description': 'List of strings of clock output signal names indexed by the first cell in the clock specifier.', 'minItems': 1, 'maxItems': 7, 'items': [{'const': 'CLKOUT0'}, {'const': 'CLKOUT1'}, {'const': 'CLKOUT2'}, {'const': 'CLKOUT3'}, {'const': 'CLKOUT4'}, {'const': 'CLKOUT5'}, {'const': 'CLKOUT6'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
/home/somlo/linux/Documentation/devicetree/bindings/clock/litex,clock.yaml: ignoring, error in schema: properties: clock-output-names
warning: no schema found in file: ./Documentation/devicetree/bindings/clock/litex,clock.yaml
DTEX Documentation/devicetree/bindings/mmc/litex,mmc.example.dts
DTEX Documentation/devicetree/bindings/media/renesas,imr.example.dts
...--- a/Documentation/devicetree/bindings/clock/litex,clock.yaml
+++ b/Documentation/devicetree/bindings/clock/litex,clock.yaml@@ -45,7 +45,6 @@ properties: List of strings of clock output signal names indexed by the first cell in the clock specifier. minItems: 1 - maxItems: 7 items: - const: CLKOUT0 - const: CLKOUT1
I have that in my local tree, but hadn't sent it to you yet, because litex,clock definitely need more work.
It appears as though `make dt_binding_check` is trying to read from `Documentation/devicetree/bindings/clock/litex,clock.yaml`, which does not exist. The clock reference I'm talking about could be *any*
Oh, it does exist in your tree ;-)
To check the examples, it has to apply all other binding files that
might apply, hence some checks are always run.
You can avoid some (but not all) such checks by adding
DT_SCHEMA_FILES=Documentation/devicetree/bindings/path/to/binding.yaml
clock elsewhere in the dts! This wasn't part of the originally reported errors, not sure why I'm seeing it now. Also, not sure what (if anything) I still need to do about it, any advice much appreciated!
Of course, as Rob doesn't have that file in his tree.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds