# Re: \[PATCH v1 3/3\] mmc: Add driver for LiteX's LiteSDCard interface

- From: Gabriel L. Somlo \<hidden\>
- Date: 2021-12-05 22:55:56 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2021/12/1596748
- Thread: https://ratatoskr.run/linux-devicetree/2021/12/1595957/t.md

```text
On Mon, Dec 06, 2021 at 06:39:36AM +0900, Stafford Horne wrote:
> On Fri, Dec 03, 2021 at 06:41:55PM -0500, Gabriel Somlo wrote:
> > LiteX (https://github.com/enjoy-digital/litex) is a SoC framework
> > that targets FPGAs. LiteSDCard is a small footprint, configurable
> > SDCard core commonly used in LiteX designs.
> > 
> > The driver was first written in May 2020 and has been maintained
> > cooperatively by the LiteX community. Thanks to all contributors!
> > 
> > Co-developed-by: Kamil Rakoczy <redacted>
> > Signed-off-by: Kamil Rakoczy <redacted>
> > Co-developed-by: Maciej Dudek <redacted>
> > Signed-off-by: Maciej Dudek <redacted>
> > Co-developed-by: Paul Mackerras <redacted>
> > Signed-off-by: Paul Mackerras <redacted>
> > Signed-off-by: Gabriel Somlo <redacted>
> > Cc: Mateusz Holenko <mholenko@antmicro.com>
> > Cc: Karol Gugala <kgugala@antmicro.com>
> > Cc: Joel Stanley <joel@jms.id.au>
> > Cc: Stafford Horne <shorne@gmail.com>
> > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> > Cc: David Abdurachmanov <redacted>
> > Cc: Florent Kermarrec <redacted>
> > ---
> >  drivers/mmc/host/Kconfig     |   6 +
> >  drivers/mmc/host/Makefile    |   1 +
> >  drivers/mmc/host/litex_mmc.c | 677 +++++++++++++++++++++++++++++++++++
> >  3 files changed, 684 insertions(+)
> >  create mode 100644 drivers/mmc/host/litex_mmc.c
> > 
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 5af8494c31b5..84c64e72195d 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -1093,3 +1093,9 @@ config MMC_OWL
> >  
> >  config MMC_SDHCI_EXTERNAL_DMA
> >  	bool
> > +
> > +config MMC_LITEX
> > +	tristate "Support for the MMC Controller in LiteX SOCs"
> > +	depends on OF && LITEX
> > +	help
> > +	  Generic MCC driver for LiteX
> 
> I just noticed this while configuring the kernel.  This doesn't really follow
> the pattern of other drivers, we should think of putting "Litex" near the
> beginning of the line. It makes it easier to spot in menuconfig.
> 
> For example:
> 
> LiteX MMC Controller support
> 
> This selects support for the MMC Host Controller found in LiteX SOCs.
> 
> It unsure, say N.

Done, and also lined up for v3. Thanks!
--Gabriel
```