Re: [PATCH net-next v4 3/6] net: lan966x: add port module support
From: Horatiu Vultur <horatiu.vultur@microchip.com>
Date: 2021-11-29 10:59:43
Also in:
lkml, netdev
From: Horatiu Vultur <horatiu.vultur@microchip.com>
Date: 2021-11-29 10:59:43
Also in:
lkml, netdev
The 11/26/2021 10:12, Jakub Kicinski wrote: Hi Jakub,
On Fri, 26 Nov 2021 10:05:37 +0100 Horatiu Vultur wrote:quoted
This patch adds support for netdev and phylink in the switch. The injection + extraction is register based. This will be replaced with DMA accees. Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>Clang sees issues here: drivers/net/ethernet/microchip/lan966x/lan966x_main.c:409:8: warning: variable 'sz' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (err != 4) ^~~~~~~~ drivers/net/ethernet/microchip/lan966x/lan966x_main.c:469:7: note: uninitialized use occurs here if (sz < 0 || err) ^~ drivers/net/ethernet/microchip/lan966x/lan966x_main.c:409:4: note: remove the 'if' if its condition is always false if (err != 4) ^~~~~~~~~~~~~ drivers/net/ethernet/microchip/lan966x/lan966x_main.c:403:9: note: initialize the variable 'sz' to silence this warning int sz, buf_len; ^ = 0
Thanks for notification. I should definitely need to start to build the kernel using Clang. -- /Horatiu