[PATCH] of: remove duplicate declarations of __of_*_sysfs() functions

Subsystems: open firmware and flattened device tree, the rest

STALE1790d LANDED

Landed in mainline as 6663ae07d995 on 2021-10-06.

2 messages, 2 authors, 2021-10-06 · open the first message on its own page

[PATCH] of: remove duplicate declarations of __of_*_sysfs() functions

From: Zev Weiss <zev@bewilderbeest.net>
Date: 2021-10-06 06:20:03

When CONFIG_OF_KOBJ was introduced in commit b56b5528f5b3 ("of: make
kobject and bin_attribute support configurable") and #ifdef-ed
versions of these declarations got added, the originals didn't get
removed.

Fixes: b56b5528f5b3 ("of: make kobject and bin_attribute support configurable")
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
---
 drivers/of/of_private.h | 8 --------
 1 file changed, 8 deletions(-)
diff --git a/drivers/of/of_private.h b/drivers/of/of_private.h
index 631489f7f8c0..75e67b8bb826 100644
--- a/drivers/of/of_private.h
+++ b/drivers/of/of_private.h
@@ -127,19 +127,11 @@ struct device_node *__of_find_node_by_full_path(struct device_node *node,
 extern const void *__of_get_property(const struct device_node *np,
 				     const char *name, int *lenp);
 extern int __of_add_property(struct device_node *np, struct property *prop);
-extern int __of_add_property_sysfs(struct device_node *np,
-		struct property *prop);
 extern int __of_remove_property(struct device_node *np, struct property *prop);
-extern void __of_remove_property_sysfs(struct device_node *np,
-		struct property *prop);
 extern int __of_update_property(struct device_node *np,
 		struct property *newprop, struct property **oldprop);
-extern void __of_update_property_sysfs(struct device_node *np,
-		struct property *newprop, struct property *oldprop);
 
-extern int __of_attach_node_sysfs(struct device_node *np);
 extern void __of_detach_node(struct device_node *np);
-extern void __of_detach_node_sysfs(struct device_node *np);
 
 extern void __of_sysfs_remove_bin_file(struct device_node *np,
 				       struct property *prop);
-- 
2.33.0

Re: [PATCH] of: remove duplicate declarations of __of_*_sysfs() functions

From: Rob Herring <robh@kernel.org>
Date: 2021-10-06 19:14:46

On Tue, 05 Oct 2021 23:19:42 -0700, Zev Weiss wrote:
When CONFIG_OF_KOBJ was introduced in commit b56b5528f5b3 ("of: make
kobject and bin_attribute support configurable") and #ifdef-ed
versions of these declarations got added, the originals didn't get
removed.

Fixes: b56b5528f5b3 ("of: make kobject and bin_attribute support configurable")
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
---
 drivers/of/of_private.h | 8 --------
 1 file changed, 8 deletions(-)
Applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help