[PATCH] arm64: dts: qcom: sc7280: Move the SD CD GPIO pin out of the dtsi file

Subsystems: arm/qualcomm chromebook support, arm/qualcomm mailing list, arm/qualcomm support, the rest

STALE1860d LANDED

Landed in mainline as 65751ebea0a7 on 2021-09-21.

4 messages, 3 authors, 2021-09-16 · open the first message on its own page

[PATCH] arm64: dts: qcom: sc7280: Move the SD CD GPIO pin out of the dtsi file

From: Douglas Anderson <dianders@chromium.org>
Date: 2021-08-30 15:07:11

There's nothing magical about GPIO91 and boards could use different
GPIOs for card detect. Move the pin out of the dtsi file and to the
only existing board file.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 +
 arch/arm64/boot/dts/qcom/sc7280.dtsi     | 4 ----
 2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index 371a2a9dcf7a..ed9f9283b71d 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -336,6 +336,7 @@ data {
 	};
 
 	sd-cd {
+		pins = "gpio91";
 		bias-pull-up;
 	};
 };
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 53a21d086178..99e946a33fbb 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -1573,10 +1573,6 @@ cmd {
 				data {
 					pins = "sdc2_data";
 				};
-
-				sd-cd {
-					pins = "gpio91";
-				};
 			};
 
 			sdc2_off: sdc2-off {
-- 
2.33.0.259.gc128427fd7-goog

Re: [PATCH] arm64: dts: qcom: sc7280: Move the SD CD GPIO pin out of the dtsi file

From: Matthias Kaehlcke <mka@chromium.org>
Date: 2021-08-30 15:52:00

On Mon, Aug 30, 2021 at 08:06:37AM -0700, Douglas Anderson wrote:
There's nothing magical about GPIO91 and boards could use different
GPIOs for card detect. Move the pin out of the dtsi file and to the
only existing board file.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>

Re: [PATCH] arm64: dts: qcom: sc7280: Move the SD CD GPIO pin out of the dtsi file

From: Stephen Boyd <hidden>
Date: 2021-08-30 22:59:18

Quoting Douglas Anderson (2021-08-30 08:06:37)
There's nothing magical about GPIO91 and boards could use different
GPIOs for card detect. Move the pin out of the dtsi file and to the
only existing board file.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
Reviewed-by: Stephen Boyd <redacted>

Re: [PATCH] arm64: dts: qcom: sc7280: Move the SD CD GPIO pin out of the dtsi file

From: Doug Anderson <dianders@chromium.org>
Date: 2021-09-16 15:28:06

Hi,

On Mon, Aug 30, 2021 at 8:07 AM Douglas Anderson [off-list ref] wrote:
There's nothing magical about GPIO91 and boards could use different
GPIOs for card detect. Move the pin out of the dtsi file and to the
only existing board file.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 +
 arch/arm64/boot/dts/qcom/sc7280.dtsi     | 4 ----
 2 files changed, 1 insertion(+), 4 deletions(-)
If there are no concerns with this patch, I think it's ready to land
now. Thanks!

-Doug
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help