Re: [PATCH RESEND 1/2] ASoC: max98927: Handle reset gpio when probing i2c
From: Alejandro Tafalla <hidden>
Date: 2021-08-29 22:13:47
(no body)
Re: [PATCH RESEND 1/2] ASoC: max98927: Handle reset gpio when probing i2c
2 messages, 2 authors, 2021-09-02 · open the first message on its own page
Re: [PATCH RESEND 1/2] ASoC: max98927: Handle reset gpio when probing i2c
From: Mark Brown <broonie@kernel.org>
Date: 2021-09-02 14:44:38
On Mon, Aug 30, 2021 at 12:13:41AM +0200, Alejandro Tafalla wrote:
On Sun, Aug 29, 2021 at 11:22:35PM +0300, Andy Shevchenko wrote:
quoted
quoted
+ struct gpio_desc *reset_gpio;
quoted
Why? Are you using it outside of ->probe()?
No, I'll delete it and use a local variable.
It can be good to reassert reset when unloading the driver in order to ensure that the device isn't active. It doesn't really matter though.