[PATCH 1/2] arm64: dts: mediatek: align operating-points table name with dtschema

Subsystems: arm/mediatek soc support, the rest

STALE1640d LANDED

Landed in mainline as 6f117db41239 on 2022-04-26.

6 messages, 3 authors, 2022-04-19 · open the first message on its own page

[PATCH 1/2] arm64: dts: mediatek: align operating-points table name with dtschema

From: Krzysztof Kozlowski <hidden>
Date: 2021-08-20 08:25:53

Align the name of operating-points node to dtschema to fix warnings like:

  arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml:
    opp_table0: $nodename:0: 'opp_table0' does not match '^opp-table(-[a-z0-9]+)?$'

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index d9e005ae5bb0..49c6b6a5b489 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -57,7 +57,7 @@ aliases {
 		serial3 = &uart3;
 	};
 
-	cluster0_opp: opp_table0 {
+	cluster0_opp: opp-table-0 {
 		compatible = "operating-points-v2";
 		opp-shared;
 		opp-507000000 {
@@ -94,7 +94,7 @@ opp-1703000000 {
 		};
 	};
 
-	cluster1_opp: opp_table1 {
+	cluster1_opp: opp-table-1 {
 		compatible = "operating-points-v2";
 		opp-shared;
 		opp-507000000 {
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 409cf827970c..caab109add28 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -197,7 +197,7 @@ CLUSTER_SLEEP1: cluster-sleep-1 {
 		};
 	};
 
-	gpu_opp_table: opp_table0 {
+	gpu_opp_table: opp-table-0 {
 		compatible = "operating-points-v2";
 		opp-shared;
 
-- 
2.30.2

[PATCH 2/2] arm64: dts: mediatek: align thermal zone node names with dtschema

From: Krzysztof Kozlowski <hidden>
Date: 2021-08-20 08:25:41

Align the name of thermal zone node to dtschema to fix warnings like:

  arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml:
    thermal-zones: 'cpu_thermal' does not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <redacted>
---
 arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 4 ++--
 arch/arm64/boot/dts/mediatek/mt8173.dtsi  | 2 +-
 arch/arm64/boot/dts/mediatek/mt8183.dtsi  | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
index a9cca9c146fd..640d4fdaa611 100644
--- a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
@@ -19,7 +19,7 @@ / {
 	#address-cells = <2>;
 	#size-cells = <2>;
 
-	cluster0_opp: opp_table0 {
+	cluster0_opp: opp-table-0 {
 		compatible = "operating-points-v2";
 		opp-shared;
 		opp00 {
@@ -36,7 +36,7 @@ opp02 {
 		};
 	};
 
-	cluster1_opp: opp_table1 {
+	cluster1_opp: opp-table-1 {
 		compatible = "operating-points-v2";
 		opp-shared;
 		opp00 {
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index 49c6b6a5b489..066025d80ca4 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -273,7 +273,7 @@ cpum_ck: oscillator2 {
 	};
 
 	thermal-zones {
-		cpu_thermal: cpu_thermal {
+		cpu_thermal: cpu-thermal {
 			polling-delay-passive = <1000>; /* milliseconds */
 			polling-delay = <1000>; /* milliseconds */
 
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index caab109add28..d836769b87bb 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -759,7 +759,7 @@ thermal: thermal@1100b000 {
 		};
 
 		thermal_zones: thermal-zones {
-			cpu_thermal: cpu_thermal {
+			cpu_thermal: cpu-thermal {
 				polling-delay-passive = <100>;
 				polling-delay = <500>;
 				thermal-sensors = <&thermal 0>;
-- 
2.30.2

Re: [PATCH 1/2] arm64: dts: mediatek: align operating-points table name with dtschema

From: Krzysztof Kozlowski <hidden>
Date: 2022-04-19 10:12:37

On Fri, 20 Aug 2021 10:16:15 +0200, Krzysztof Kozlowski wrote:
Align the name of operating-points node to dtschema to fix warnings like:

  arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml:
    opp_table0: $nodename:0: 'opp_table0' does not match '^opp-table(-[a-z0-9]+)?$'
Applied, thanks!

[1/2] arm64: dts: mediatek: align operating-points table name with dtschema
      commit: c743bb394d35b782ae9d9ab815d6053500914533
[2/2] arm64: dts: mediatek: align thermal zone node names with dtschema
      commit: 54ff423f837db59db0626a00d091e45dcc46787e

Best regards,
-- 
Krzysztof Kozlowski [off-list ref]

Re: [PATCH 1/2] arm64: dts: mediatek: align operating-points table name with dtschema

From: Matthias Brugger <matthias.bgg@gmail.com>
Date: 2022-04-19 14:32:09


On 19/04/2022 12:12, Krzysztof Kozlowski wrote:
On Fri, 20 Aug 2021 10:16:15 +0200, Krzysztof Kozlowski wrote:
quoted
Align the name of operating-points node to dtschema to fix warnings like:

   arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml:
     opp_table0: $nodename:0: 'opp_table0' does not match '^opp-table(-[a-z0-9]+)?$'
Applied, thanks!
Could you please provide a stable branch for this patches? So that I can pull that into my branch. This will help to reduce merge conflicts later on.

Thanks,
Matthias
[1/2] arm64: dts: mediatek: align operating-points table name with dtschema
       commit: c743bb394d35b782ae9d9ab815d6053500914533
[2/2] arm64: dts: mediatek: align thermal zone node names with dtschema
       commit: 54ff423f837db59db0626a00d091e45dcc46787e

Best regards,

Re: [PATCH 1/2] arm64: dts: mediatek: align operating-points table name with dtschema

From: Krzysztof Kozlowski <hidden>
Date: 2022-04-19 14:35:41

On 19/04/2022 16:31, Matthias Brugger wrote:
On 19/04/2022 12:12, Krzysztof Kozlowski wrote:
quoted
On Fri, 20 Aug 2021 10:16:15 +0200, Krzysztof Kozlowski wrote:
quoted
Align the name of operating-points node to dtschema to fix warnings like:

   arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml:
     opp_table0: $nodename:0: 'opp_table0' does not match '^opp-table(-[a-z0-9]+)?$'
Applied, thanks!
Could you please provide a stable branch for this patches? So that I can pull 
that into my branch. This will help to reduce merge conflicts later on.
Then maybe better take them directly? These patches were waiting on
lists for long time, I resent them and pinged. I took them only because
there seems to be little interest but we want to fix all dtbs_check
warnings.

There are three for Mediatek:

https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/log/?h=for-v5.19/arm-dts64-cleanups

Best regards,
Krzysztof

Re: [PATCH 1/2] arm64: dts: mediatek: align operating-points table name with dtschema

From: Matthias Brugger <matthias.bgg@gmail.com>
Date: 2022-04-19 14:51:11


On 19/04/2022 16:34, Krzysztof Kozlowski wrote:
On 19/04/2022 16:31, Matthias Brugger wrote:
quoted
On 19/04/2022 12:12, Krzysztof Kozlowski wrote:
quoted
On Fri, 20 Aug 2021 10:16:15 +0200, Krzysztof Kozlowski wrote:
quoted
Align the name of operating-points node to dtschema to fix warnings like:

    arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml:
      opp_table0: $nodename:0: 'opp_table0' does not match '^opp-table(-[a-z0-9]+)?$'
Applied, thanks!
Could you please provide a stable branch for this patches? So that I can pull
that into my branch. This will help to reduce merge conflicts later on.
Then maybe better take them directly? These patches were waiting on
lists for long time, I resent them and pinged. I took them only because
there seems to be little interest but we want to fix all dtbs_check
warnings.
Yes definitely. I'm just overloaded and forgot about them. Although at least on that thread I don't see any ping. Anway thanks for the tag, I merged it into my branch now, so we are good.

Regards,
Matthias
There are three for Mediatek:

https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/log/?h=for-v5.19/arm-dts64-cleanups

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help