@@ -1,22 +0,0 @@-Bindings for the Maxim MAX31785 Intelligent Fan Controller-==========================================================--Reference:--https://datasheets.maximintegrated.com/en/ds/MAX31785.pdf--The Maxim MAX31785 is a PMBus device providing closed-loop, multi-channel fan-management with temperature and remote voltage sensing. Various fan control-features are provided, including PWM frequency control, temperature hysteresis,-dual tachometer measurements, and fan health monitoring.--Required properties:-- compatible : One of "maxim,max31785" or "maxim,max31785a"-- reg : I2C address, one of 0x52, 0x53, 0x54, 0x55.--Example:-- fans@52 {- compatible = "maxim,max31785";- reg = <0x52>;- };
@@ -163,6 +163,10 @@ properties:-maxim,max6625# 3-Channel Remote Temperature Sensor-maxim,max31730+# Intelligent Fan Controller with temperature and remote voltage sensing+# Datasheet: https://datasheets.maximintegrated.com/en/ds/MAX31785.pdf+-maxim,max31785+-maxim,max31785a# mCube 3-axis 8-bit digital accelerometer-mcube,mc3230# Measurement Specialities I2C temperature and humidity sensor
Ther Maxim max31785 bindings are trivial, so simply merge it into
trivial-devices.yaml.
Signed-off-by: Krzysztof Kozlowski <redacted>
---
.../devicetree/bindings/hwmon/max31785.txt | 22 -------------------
Not sure if that is a good idea. It would make more sense to standardize the
properties needed by the driver/chip instead (see existing dts files in the kernel).
Guenter
Ther Maxim max1619 bindings are trivial, so simply merge it into
trivial-devices.yaml.
Signed-off-by: Krzysztof Kozlowski <redacted>
Do we have a general guideline on how to handle such trivial bindings ?
I normally leave it up to the driver author to decide one way or another.
Guenter
From: Rob Herring <robh+dt@kernel.org> Date: 2021-08-23 21:12:37
On Fri, Aug 20, 2021 at 9:23 AM Guenter Roeck [off-list ref] wrote:
On 8/19/21 11:25 AM, Krzysztof Kozlowski wrote:
quoted
Ther Maxim max31785 bindings are trivial, so simply merge it into
trivial-devices.yaml.
Signed-off-by: Krzysztof Kozlowski <redacted>
---
.../devicetree/bindings/hwmon/max31785.txt | 22 -------------------
Not sure if that is a good idea. It would make more sense to standardize the
properties needed by the driver/chip instead (see existing dts files in the kernel).
This device is certainly not trivial, the binding is just incomplete.
Device specific fan controller bindings are something I'm just going
to reject until someone comes up with something common.
Rob
From: Rob Herring <robh+dt@kernel.org> Date: 2021-08-23 21:20:03
On Fri, Aug 20, 2021 at 9:26 AM Guenter Roeck [off-list ref] wrote:
On 8/19/21 11:25 AM, Krzysztof Kozlowski wrote:
quoted
Ther Maxim max1619 bindings are trivial, so simply merge it into
trivial-devices.yaml.
Signed-off-by: Krzysztof Kozlowski <redacted>
Do we have a general guideline on how to handle such trivial bindings ?
Not really. I debate (with myself) just getting rid of it as I suspect
lots of bindings are just incomplete. Like should supplies be
required? But it's convenient to have and not duplicate a bunch of
boilerplate.
I normally leave it up to the driver author to decide one way or another.
Me too.
This one looks simple enough to be in trivial-devices, so I'll take
having a schema over not.
Rob