[PATCH v1] arm64: dts: qcom: sc7280: Add clock controller ID headers

Subsystems: arm/qualcomm chromebook support, arm/qualcomm mailing list, arm/qualcomm support, the rest

STALE1852d LANDED

Landed in mainline as c8efde9f6b18 on 2021-09-21.

3 messages, 2 authors, 2021-09-16 · open the first message on its own page

[PATCH v1] arm64: dts: qcom: sc7280: Add clock controller ID headers

From: Taniya Das <hidden>
Date: 2021-08-11 00:44:05

Add the GPUCC, DISPCC and VIDEOCC clock headers which were dropped
earlier.

Fixes: 422a295221bb ("arm64: dts: qcom: sc7280: Add clock controller nodes")
Signed-off-by: Taniya Das <redacted>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 53a21d0..3e96604 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -5,8 +5,11 @@
  * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
  */

+#include <dt-bindings/clock/qcom,dispcc-sc7280.h>
 #include <dt-bindings/clock/qcom,gcc-sc7280.h>
+#include <dt-bindings/clock/qcom,gpucc-sc7280.h>
 #include <dt-bindings/clock/qcom,rpmh.h>
+#include <dt-bindings/clock/qcom,videocc-sc7280.h>
 #include <dt-bindings/interconnect/qcom,sc7280.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/mailbox/qcom-ipcc.h>
--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the  Linux Foundation.

Re: [PATCH v1] arm64: dts: qcom: sc7280: Add clock controller ID headers

From: Doug Anderson <dianders@chromium.org>
Date: 2021-08-24 22:52:33

Hi,

On Tue, Aug 10, 2021 at 5:43 PM Taniya Das [off-list ref] wrote:
Add the GPUCC, DISPCC and VIDEOCC clock headers which were dropped
earlier.

Fixes: 422a295221bb ("arm64: dts: qcom: sc7280: Add clock controller nodes")
IMO drop the "Fixes". To me having the "Fixes" there means that there
was a bug in the old patch. This isn't really fixing a bug.
Signed-off-by: Taniya Das <redacted>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
 1 file changed, 3 insertions(+)
Other than removing the "Fixes" then this seems like it would be nice
to land soon after the next -rc1 comes out so that patches that start
referring to the clocks in these controllers can take advantage of
them. Snooze 3 weeks till (presumably) -rc1 might come out.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Re: [PATCH v1] arm64: dts: qcom: sc7280: Add clock controller ID headers

From: Doug Anderson <dianders@chromium.org>
Date: 2021-09-16 15:39:38

Hi,

On Tue, Aug 24, 2021 at 3:52 PM Doug Anderson [off-list ref] wrote:
Hi,

On Tue, Aug 10, 2021 at 5:43 PM Taniya Das [off-list ref] wrote:
quoted
Add the GPUCC, DISPCC and VIDEOCC clock headers which were dropped
earlier.

Fixes: 422a295221bb ("arm64: dts: qcom: sc7280: Add clock controller nodes")
IMO drop the "Fixes". To me having the "Fixes" there means that there
was a bug in the old patch. This isn't really fixing a bug.
quoted
Signed-off-by: Taniya Das <redacted>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
 1 file changed, 3 insertions(+)
Other than removing the "Fixes" then this seems like it would be nice
to land soon after the next -rc1 comes out so that patches that start
referring to the clocks in these controllers can take advantage of
them. Snooze 3 weeks till (presumably) -rc1 might come out.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Bjorn: if you agree and are willing to drop the "Fixes" line yourself
when applying then I think this is ready to land since it's now "soon
after the next -rc1". ;-)

-Doug
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help