Thread (9 messages) 9 messages, 3 authors, 2021-07-12

Re: [PATCH 2/2] dt-bindings: rtc: add Epson RX-8025 and RX-8035

From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: 2021-07-10 00:41:03
Also in: linux-rtc

Hello,

On 09/07/2021 16:19:49+0900, Nobuhiro Iwamatsu wrote:
Hi,

2021年7月8日(木) 6:52 Alexandre Belloni [off-list ref]:
quoted
On 08/07/2021 06:46:31+0900, Nobuhiro Iwamatsu wrote:
quoted
Hi,

2021年7月7日(水) 16:17 Mathew McBride [off-list ref]:
quoted
These are supported by the rtc-rx8025 module. RX-8025
also has support in ds1307 due to compatible time registers.

Signed-off-by: Mathew McBride <redacted>
---
 Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
index 7548d8714871..13925bb78ec7 100644
--- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
@@ -32,6 +32,9 @@ properties:
       - dallas,ds3232
       # I2C-BUS INTERFACE REAL TIME CLOCK MODULE
       - epson,rx8010
+      # I2C-BUS INTERFACE REAL TIME CLOCK MODULE
+      - epson,rx8025
+      - epson,rx8035
'epson,rx8035' is unnsecessary.
This lists compatible string, so we don't list compatible that doesn't exist.
Well, the previous patch adds it.
I couldn't find anything to add "epson,rx8035" as device tree compatible in
previous patch(rtc: rx8025: implement RX-8035 support)....
I think that i2c_device_id was added and it is not device tree compatible.
Can you tell me if my understanding is wrong?
Having "rx8035" in the struct i2c_device_id array is enough to have the
driver probed using DT. IIRC, it is a side effect of
i2c_of_match_device_sysfs()

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help