# Re: \[PATCH v13 01/12\] swiotlb: Refactor swiotlb init functions

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2021-06-21 20:19:55 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2021/06/1421747
- Thread: https://ratatoskr.run/linux-devicetree/2021/06/1417526/t.md

```text
On Mon, Jun 21, 2021 at 10:59:20AM -0700, Stefano Stabellini wrote:
> Just as a clarification: I was referring to the zeroing of "mem" in
> swiotlb_late_init_with_tbl and swiotlb_init_with_tbl. While it looks
> like Tom and Christoph are talking about the zeroing of "tlb".

Indeed. 

> 
> The zeroing of "mem" is required as some fields of struct io_tlb_mem
> need to be initialized to zero. While the zeroing of "tlb" is not
> required except from the point of view of not leaking sensitive data as
> Christoph mentioned.
> 
> Either way, Claire's v14 patch 01/12 looks fine to me.

Agreed.
```
