[PATCH RESEND 0/2] Add GMAC_AHB_RESET to ipq8064 ethernet resets

STALE1870d

4 messages, 2 authors, 2021-06-18 · open the first message on its own page

[PATCH RESEND 0/2] Add GMAC_AHB_RESET to ipq8064 ethernet resets

From: Matthew Hagan <hidden>
Date: 2021-06-09 23:11:32

These two additional patches were dropped at v2, v3 by error and
should have been included with "net: stmmac: explicitly deassert
GMAC_AHB_RESET". These add GMAC_AHB_RESET to the ipq8064 ethernet
reset definitions and documentation.

Apologies for the oversight.

Matthew Hagan (2):
  ARM: dts: qcom: add ahb reset to ipq806x-gmac
  dt-bindings: net: stmmac: add ahb reset to example

 .../devicetree/bindings/net/ipq806x-dwmac.txt |  5 +++--
 arch/arm/boot/dts/qcom-ipq8064.dtsi           | 20 +++++++++++--------
 2 files changed, 15 insertions(+), 10 deletions(-)

-- 
2.26.3

[PATCH RESEND 2/2] dt-bindings: net: stmmac: add ahb reset to example

From: Matthew Hagan <hidden>
Date: 2021-06-09 23:10:35

Add ahb reset to the reset properties within the example GMAC node.

Signed-off-by: Matthew Hagan <redacted>
---
 Documentation/devicetree/bindings/net/ipq806x-dwmac.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/ipq806x-dwmac.txt b/Documentation/devicetree/bindings/net/ipq806x-dwmac.txt
index 6d7ab4e524d4..ef5fd9f0b156 100644
--- a/Documentation/devicetree/bindings/net/ipq806x-dwmac.txt
+++ b/Documentation/devicetree/bindings/net/ipq806x-dwmac.txt

@@ -30,6 +30,7 @@ Example:
 		clocks = <&gcc GMAC_CORE1_CLK>;
 		clock-names = "stmmaceth";
 
-		resets = <&gcc GMAC_CORE1_RESET>;
-		reset-names = "stmmaceth";
+		resets = <&gcc GMAC_CORE1_RESET>,
+			 <&gcc GMAC_AHB_RESET>;
+		reset-names = "stmmaceth", "ahb";
 	};

-- 
2.26.3

Re: [PATCH RESEND 2/2] dt-bindings: net: stmmac: add ahb reset to example

From: Rob Herring <robh@kernel.org>
Date: 2021-06-18 21:18:47

On Thu, 10 Jun 2021 00:09:45 +0100, Matthew Hagan wrote:

Add ahb reset to the reset properties within the example GMAC node.

Signed-off-by: Matthew Hagan <redacted>
---
 Documentation/devicetree/bindings/net/ipq806x-dwmac.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

[PATCH RESEND 1/2] ARM: dts: qcom: add ahb reset to ipq806x-gmac

From: Matthew Hagan <hidden>
Date: 2021-06-09 23:11:36

Add GMAC_AHB_RESET to the resets property of each GMAC node.

Signed-off-by: Matthew Hagan <redacted>
---
 arch/arm/boot/dts/qcom-ipq8064.dtsi | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
index 98995ead4413..1dbceaf3454b 100644
--- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi

@@ -643,8 +643,9 @@ gmac0: ethernet@37000000 {
 			clocks = <&gcc GMAC_CORE1_CLK>;
 			clock-names = "stmmaceth";
 
-			resets = <&gcc GMAC_CORE1_RESET>;
-			reset-names = "stmmaceth";
+			resets = <&gcc GMAC_CORE1_RESET>,
+				 <&gcc GMAC_AHB_RESET>;
+			reset-names = "stmmaceth", "ahb";
 
 			status = "disabled";
 		};

@@ -666,8 +667,9 @@ gmac1: ethernet@37200000 {
 			clocks = <&gcc GMAC_CORE2_CLK>;
 			clock-names = "stmmaceth";
 
-			resets = <&gcc GMAC_CORE2_RESET>;
-			reset-names = "stmmaceth";
+			resets = <&gcc GMAC_CORE2_RESET>,
+				 <&gcc GMAC_AHB_RESET>;
+			reset-names = "stmmaceth", "ahb";
 
 			status = "disabled";
 		};

@@ -689,8 +691,9 @@ gmac2: ethernet@37400000 {
 			clocks = <&gcc GMAC_CORE3_CLK>;
 			clock-names = "stmmaceth";
 
-			resets = <&gcc GMAC_CORE3_RESET>;
-			reset-names = "stmmaceth";
+			resets = <&gcc GMAC_CORE3_RESET>,
+				 <&gcc GMAC_AHB_RESET>;
+			reset-names = "stmmaceth", "ahb";
 
 			status = "disabled";
 		};

@@ -712,8 +715,9 @@ gmac3: ethernet@37600000 {
 			clocks = <&gcc GMAC_CORE4_CLK>;
 			clock-names = "stmmaceth";
 
-			resets = <&gcc GMAC_CORE4_RESET>;
-			reset-names = "stmmaceth";
+			resets = <&gcc GMAC_CORE4_RESET>,
+				 <&gcc GMAC_AHB_RESET>;
+			reset-names = "stmmaceth", "ahb";
 
 			status = "disabled";
 		};

-- 
2.26.3

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help