On Fri, May 7, 2021 at 5:52 PM Joakim Tjernlund
[off-list ref] wrote:

On Fri, 2021-05-07 at 14:46 +0300, Andy Shevchenko wrote:

quoted

On Fri, May 7, 2021 at 3:40 AM Chris Packham
[off-list ref] wrote:

...

quoted

So, now you may shrink it even further, i.e.

       void __iomem *sr = i2c->base + MPC_I2C_SR;
       u8 val;

       return readb_poll_timeout(sr, val, val & mask, 0, 100);

val looks uninitialised before use?

Nope.

Thinking about naming, perhaps

        void __iomem *addr = i2c->base + MPC_I2C_SR;
        u8 sr; // or leave as val?

        return readb_poll_timeout(addr, sr, sr & mask, 0, 100);

would be more clear.

-- 
With Best Regards,
Andy Shevchenko