Thread (14 messages) 14 messages, 5 authors, 2021-03-28

Re: [PATCH 1/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver

From: Pavel Machek <hidden>
Date: 2021-03-24 10:43:16
Also in: linux-leds, lkml

Hi!
quoted
+	of_property_read_string(node, "default-state", &state);
+	if (!strcmp(state, "on"))
+		multi_gpio_led_set(&priv->cdev, LED_FULL);
+	else
+		multi_gpio_led_set(&priv->cdev, LED_OFF);
Again LED_FULL and LED_OFF...
What about default-state = "keep" ?
Let's not support default-state unless you need it.

Best regards,
							Pavel
-- 
http://www.livejournal.com/~pavelmachek

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help