# Re: \[PATCH v5 02/15\] gpio: regmap: set gpio\_chip of\_node

- From: Andy Shevchenko \<hidden\>
- Date: 2021-03-06 16:27:23 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2021/03/6290934
- Thread: https://ratatoskr.run/linux-gpio/2021/03/6290908/t.md

```text
On Sat, Mar 6, 2021 at 5:57 PM Álvaro Fernández Rojas [ref] wrote:
>
> This is needed for properly registering GPIO regmap as a child of a regmap
> pin controller.

Thanks for an update!

...

>         chip->parent = config->parent;

> +       if (config->fwnode)

This...

> +               chip->of_node = to_of_node(config->fwnode);

> +       else
> +               chip->of_node = dev_of_node(config->parent);

...and these lines are not needed. If there is no of_node in the chip,
the GPIO library will take care of it to be parent's one.

-- 
With Best Regards,
Andy Shevchenko
```
