# Re: \[RFT PATCH v3 21/27\] tty: serial: samsung\_tty: IRQ rework

- From: Andy Shevchenko \<hidden\>
- Date: 2021-03-05 16:21:23 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2021/03/6290144
- Thread: https://ratatoskr.run/linux-arm-kernel/2021/03/6288800/t.md

```text
On Fri, Mar 5, 2021 at 6:16 PM Hector Martin [ref] wrote:
>
> On 06/03/2021 00.17, Andy Shevchenko wrote:
> > Add a separate change that removes flags from the spin lock in the IRQ handler.
>
> This commit should have no functional changes;

Exactly my point why I'm suggesting to have _separate_ change!

> I am just splitting an
> existing function into two, where one takes the lock and the other does
> the work. Do you mean using a different locking function? I'm not
> entirely sure what you're suggesting.

Yes, as a prerequisite

spin_lock_irqsave -> spin_lock().

-- 
With Best Regards,
Andy Shevchenko
```
