# Re: \[PATCH 3/3\] dt-bindings: Fix errors in 'if' schemas

- From: Nicolas Saenz Julienne \<hidden\>
- Date: 2021-02-03 11:57:23 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2021/02/6256940
- Thread: https://ratatoskr.run/linux-devicetree/2021/02/6256241/t.md

```text
On Tue, 2021-02-02 at 14:55 -0600, Rob Herring wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
> 
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entries. 'contains' is the correct schema
> to use in the case of multiple entries.
> 
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Chen-Yu Tsai <redacted>
> Cc: Eric Anholt <redacted>
> Cc: Nicolas Saenz Julienne <redacted>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Pavel Machek <redacted>
> Cc: Ulf Hansson <redacted>
> Cc: Kishon Vijay Abraham I <redacted>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Linus Walleij <redacted>
> Cc: Daniel Lezcano <redacted>
> Cc: <redacted>
> Cc: <redacted>
> Cc: <redacted>
> Cc: <redacted>
> Cc: <redacted>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---

Reviewed-by: Nicolas Saenz Julienne <redacted>

```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-devicetree/2021/02/6256940/attachment/0) (application/pgp-signature, 488 bytes)
