From: Rob Herring <robh@kernel.org> Date: 2021-02-02 18:17:29
The example uses 'adi,ad5686', but the schema fails to document it. Given
the filename and there is a similar part AD5686, let's just add the
compatible strings including the 'r' variant.
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Michael Hennerich <Michael.Hennerich@analog.com>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Peter Meerwald-Stadler <redacted>
Cc: Michael Auchter <redacted>
Cc: linux-iio@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++
1 file changed, 2 insertions(+)
The example uses 'adi,ad5686', but the schema fails to document it. Given
the filename and there is a similar part AD5686, let's just add the
compatible strings including the 'r' variant.
There are two variants of this chip. One with a SPI interface and one with a I2C interface. This binding document only describes the I2C variants. But the ad5686 is a SPI variant.
I think this is a typo and we should replace ad5686 with ad5696, including the document name.
quoted hunk
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Michael Hennerich <Michael.Hennerich@analog.com>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Peter Meerwald-Stadler <redacted>
Cc: Michael Auchter <redacted>
Cc: linux-iio@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++
1 file changed, 2 insertions(+)
From: Rob Herring <robh@kernel.org> Date: 2021-02-02 21:11:21
On Tue, Feb 02, 2021 at 09:55:56PM +0100, Lars-Peter Clausen wrote:
On 2/2/21 7:14 PM, Rob Herring wrote:
quoted
The example uses 'adi,ad5686', but the schema fails to document it. Given
the filename and there is a similar part AD5686, let's just add the
compatible strings including the 'r' variant.
There are two variants of this chip. One with a SPI interface and one with a
I2C interface. This binding document only describes the I2C variants. But
the ad5686 is a SPI variant.
Right, I should have noticed that.
I think this is a typo and we should replace ad5686 with ad5696, including
the document name.
Though we do frequently document both I2C and SPI variants in the same
binding, given there's no existing SPI support and the example is wrong
I agree.
quoted
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Michael Hennerich <Michael.Hennerich@analog.com>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Peter Meerwald-Stadler <redacted>
Cc: Michael Auchter <redacted>
Cc: linux-iio@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++
1 file changed, 2 insertions(+)
From: Jonathan Cameron <jic23@kernel.org> Date: 2021-02-06 15:56:23
On Tue, 2 Feb 2021 15:10:22 -0600
Rob Herring [off-list ref] wrote:
On Tue, Feb 02, 2021 at 09:55:56PM +0100, Lars-Peter Clausen wrote:
quoted
On 2/2/21 7:14 PM, Rob Herring wrote:
quoted
The example uses 'adi,ad5686', but the schema fails to document it. Given
the filename and there is a similar part AD5686, let's just add the
compatible strings including the 'r' variant.
There are two variants of this chip. One with a SPI interface and one with a
I2C interface. This binding document only describes the I2C variants. But
the ad5686 is a SPI variant.
Right, I should have noticed that.
quoted
I think this is a typo and we should replace ad5686 with ad5696, including
the document name.
Though we do frequently document both I2C and SPI variants in the same
binding, given there's no existing SPI support and the example is wrong
I agree.
Ah, this is what I get for reading my emails out of order.
There is existing SPI driver support if that's what you mean
we just haven't documented the binding for it.
Should work via the fallbacks in SPI that drop the vendor id off then match
on the rest. As I mentioned in reply to v2. It's an old driver so
kind of got DT support by accident.
I'll play catch up at some stage soon on missing binding docs,
(I suspect there are quite a few for older IIO drivers)
Thanks,
Jonathan
quoted
quoted
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Michael Hennerich <Michael.Hennerich@analog.com>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Peter Meerwald-Stadler <redacted>
Cc: Michael Auchter <redacted>
Cc: linux-iio@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++
1 file changed, 2 insertions(+)