[PATCH v1 net] dt-bindings: net: dwmac: fix queue priority documentation

Subsystems: networking drivers, open firmware and flattened device tree bindings, the rest

STALE2035d LANDED

Landed in mainline as 938288349ca8 on 2021-01-11.

2 messages, 2 authors, 2021-01-12 · open the first message on its own page

[PATCH v1 net] dt-bindings: net: dwmac: fix queue priority documentation

From: Sebastien Laveze <hidden>
Date: 2021-01-11 08:15:43

From: Seb Laveze <redacted>

The priority field is not the queue priority (queue priority is fixed)
but a bitmask of priorities assigned to this queue.

In receive, priorities relate to tagged frames priorities.

In transmit, priorities relate to PFC frames.

Signed-off-by: Seb Laveze <redacted>
---
 Documentation/devicetree/bindings/net/snps,dwmac.yaml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index b2f6083f556a..dfbf5fe4547a 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -161,7 +161,8 @@ properties:
             * snps,route-dcbcp, DCB Control Packets
             * snps,route-up, Untagged Packets
             * snps,route-multi-broad, Multicast & Broadcast Packets
-          * snps,priority, RX queue priority (Range 0x0 to 0xF)
+          * snps,priority, bitmask of the tagged frames priorities assigned to
+            the queue
 
   snps,mtl-tx-config:
     $ref: /schemas/types.yaml#/definitions/phandle
@@ -188,7 +189,10 @@ properties:
             * snps,idle_slope, unlock on WoL
             * snps,high_credit, max write outstanding req. limit
             * snps,low_credit, max read outstanding req. limit
-          * snps,priority, TX queue priority (Range 0x0 to 0xF)
+          * snps,priority, bitmask of the priorities assigned to the queue.
+            When a PFC frame is received with priorities matching the bitmask,
+            the queue is blocked from transmitting for the pause time specified
+            in the PFC frame.
 
   snps,reset-gpio:
     deprecated: true
-- 
2.25.1

Re: [PATCH v1 net] dt-bindings: net: dwmac: fix queue priority documentation

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-01-12 00:30:50

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 11 Jan 2021 09:14:07 +0100 you wrote:
From: Seb Laveze <redacted>

The priority field is not the queue priority (queue priority is fixed)
but a bitmask of priorities assigned to this queue.

In receive, priorities relate to tagged frames priorities.

[...]
Here is the summary with links:
  - [v1,net] dt-bindings: net: dwmac: fix queue priority documentation
    https://git.kernel.org/netdev/net/c/938288349ca8

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help