[PATCH net] dt-bindings: net: dwmac: fix queue priority documentation

Subsystems: networking drivers, open firmware and flattened device tree bindings, the rest

STALE2027d

3 messages, 2 authors, 2021-01-11 · open the first message on its own page

[PATCH net] dt-bindings: net: dwmac: fix queue priority documentation

From: Sebastien Laveze (OSS) <hidden>
Date: 2021-01-05 15:50:00

From: Seb Laveze <redacted>

The priority field is not the queue priority (queue priority is fixed)
but a bitmask of priorities assigned to this queue.

In receive, priorities relate to tagged frames priorities.

In transmit, priorities relate to PFC frames.

Signed-off-by: Seb Laveze <redacted>
---
 Documentation/devicetree/bindings/net/snps,dwmac.yaml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 11a6fdb657c9..9f6ba47513a7 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -161,7 +161,8 @@ properties:
             * snps,route-dcbcp, DCB Control Packets
             * snps,route-up, Untagged Packets
             * snps,route-multi-broad, Multicast & Broadcast Packets
-          * snps,priority, RX queue priority (Range 0x0 to 0xF)
+          * snps,priority, bitmask of the tagged frames priorities assigned to
+            the queue
 
   snps,mtl-tx-config:
     $ref: /schemas/types.yaml#definitions/phandle
@@ -188,7 +189,10 @@ properties:
             * snps,idle_slope, unlock on WoL
             * snps,high_credit, max write outstanding req. limit
             * snps,low_credit, max read outstanding req. limit
-          * snps,priority, TX queue priority (Range 0x0 to 0xF)
+          * snps,priority, bitmask of the priorities assigned to the queue.
+            When a PFC frame is received with priorities matching the bitmask,
+            the queue is blocked from transmitting for the pause time specified
+            in the PFC frame.
 
   snps,reset-gpio:
     deprecated: true
-- 
2.25.1

Re: [PATCH net] dt-bindings: net: dwmac: fix queue priority documentation

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-10 03:17:31

On Tue,  5 Jan 2021 16:47:48 +0100 Sebastien Laveze (OSS) wrote:
From: Seb Laveze <redacted>

The priority field is not the queue priority (queue priority is fixed)
but a bitmask of priorities assigned to this queue.

In receive, priorities relate to tagged frames priorities.

In transmit, priorities relate to PFC frames.

Signed-off-by: Seb Laveze <redacted>
Hi Sebastien, looks like this no longer applies to net could you rebase?

Re: [PATCH net] dt-bindings: net: dwmac: fix queue priority documentation

From: Sebastien Laveze <hidden>
Date: 2021-01-11 08:04:41

On Sat, 2021-01-09 at 19:16 -0800, Jakub Kicinski wrote:
Hi Sebastien, looks like this no longer applies to net could you
rebase?
Hi Jakub,
Sure, no problem.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help