[PATCH] of: base: improve error msg in of_phandle_iterator_next()

Subsystems: open firmware and flattened device tree, the rest

STALE2041d LANDED

Landed in mainline as 12e17243d8a1 on 2021-01-15.

2 messages, 2 authors, 2021-01-15 · open the first message on its own page

[PATCH] of: base: improve error msg in of_phandle_iterator_next()

From: "Enrico Weigelt, metux IT consult" <info@metux.net>
Date: 2021-01-14 10:14:09

Also print out the phandle ID on error message, as a debug aid.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 drivers/of/base.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 161a23631472..8a348f0d3c5e 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1297,8 +1297,8 @@ int of_phandle_iterator_next(struct of_phandle_iterator *it)
 
 		if (it->cells_name) {
 			if (!it->node) {
-				pr_err("%pOF: could not find phandle\n",
-				       it->parent);
+				pr_err("%pOF: could not find phandle %d\n",
+				       it->parent, it->phandle);
 				goto err;
 			}
 
-- 
2.11.0

Re: [PATCH] of: base: improve error msg in of_phandle_iterator_next()

From: Rob Herring <robh@kernel.org>
Date: 2021-01-15 17:27:11

On Thu, 14 Jan 2021 11:11:27 +0100, Enrico Weigelt, metux IT consult wrote:
Also print out the phandle ID on error message, as a debug aid.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 drivers/of/base.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help