[PATCH 0/2] mmc: AM64: Add new compatible string and driver support

STALE2025d

6 messages, 2 authors, 2021-01-13 · open the first message on its own page

[PATCH 0/2] mmc: AM64: Add new compatible string and driver support

From: Aswath Govindraju <hidden>
Date: 2021-01-13 12:01:14

The following series of patches,
- Adds new compatible string for AM64 SoC
- Adds support for AM64 SoC in sdhci_am654 driver

This patch series is a combination of the patches [1] and [2].

[1] - https://lore.kernel.org/patchwork/patch/1361560/
[2] - https://lore.kernel.org/patchwork/patch/1364589/

Aswath Govindraju (1):
  dt-bindings: mmc: sdhci-am654: Add compatible string for AM64 SoC

Faiz Abbas (1):
  mmc: sdhci_am654: Add Support for TI's AM64 SoC

 .../devicetree/bindings/mmc/sdhci-am654.yaml  |  2 ++
 drivers/mmc/host/sdhci_am654.c                | 28 +++++++++++++++++++
 2 files changed, 30 insertions(+)

-- 
2.17.1

[PATCH 2/2] mmc: sdhci_am654: Add Support for TI's AM64 SoC

From: Aswath Govindraju <hidden>
Date: 2021-01-13 12:00:31

From: Faiz Abbas <redacted>

Add support for the controller present on the AM64x SoC.

There are instances:
sdhci0: 8bit bus width, max 400 MBps
sdhci1: 4bit bus width, max 100 MBps

Signed-off-by: Faiz Abbas <redacted>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Kishon Vijay Abraham I <redacted>
Signed-off-by: Aswath Govindraju <redacted>
---
 drivers/mmc/host/sdhci_am654.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
index a64ea143d185..7a34649b0754 100644
--- a/drivers/mmc/host/sdhci_am654.c
+++ b/drivers/mmc/host/sdhci_am654.c
@@ -514,6 +514,26 @@ static const struct sdhci_am654_driver_data sdhci_j721e_4bit_drvdata = {
 	.flags = IOMUX_PRESENT,
 };
 
+static const struct sdhci_pltfm_data sdhci_am64_8bit_pdata = {
+	.ops = &sdhci_j721e_8bit_ops,
+	.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
+};
+
+static const struct sdhci_am654_driver_data sdhci_am64_8bit_drvdata = {
+	.pdata = &sdhci_am64_8bit_pdata,
+	.flags = DLL_PRESENT | DLL_CALIB,
+};
+
+static const struct sdhci_pltfm_data sdhci_am64_4bit_pdata = {
+	.ops = &sdhci_j721e_4bit_ops,
+	.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
+};
+
+static const struct sdhci_am654_driver_data sdhci_am64_4bit_drvdata = {
+	.pdata = &sdhci_am64_4bit_pdata,
+	.flags = IOMUX_PRESENT,
+};
+
 static const struct soc_device_attribute sdhci_am654_devices[] = {
 	{ .family = "AM65X",
 	  .revision = "SR1.0",
@@ -737,6 +757,14 @@ static const struct of_device_id sdhci_am654_of_match[] = {
 		.compatible = "ti,j721e-sdhci-4bit",
 		.data = &sdhci_j721e_4bit_drvdata,
 	},
+	{
+		.compatible = "ti,am64-sdhci-8bit",
+		.data = &sdhci_am64_8bit_drvdata,
+	},
+	{
+		.compatible = "ti,am64-sdhci-4bit",
+		.data = &sdhci_am64_4bit_drvdata,
+	},
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, sdhci_am654_of_match);
-- 
2.17.1

Re: [PATCH 2/2] mmc: sdhci_am654: Add Support for TI's AM64 SoC

From: Aswath Govindraju <hidden>
Date: 2021-01-13 12:08:26

Hi,

On 13/01/21 5:29 pm, Aswath Govindraju wrote:
From: Faiz Abbas <redacted>

Add support for the controller present on the AM64x SoC.

There are instances:
sdhci0: 8bit bus width, max 400 MBps
sdhci1: 4bit bus width, max 100 MBps

Signed-off-by: Faiz Abbas <redacted>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Kishon Vijay Abraham I <redacted>
Signed-off-by: Aswath Govindraju <redacted>
---
Very sorry forgot to add RESEND tag in the subject. The link to the
original patch,
https://lore.kernel.org/patchwork/patch/1364589/

Thanks,
Aswath
quoted hunk
 drivers/mmc/host/sdhci_am654.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
index a64ea143d185..7a34649b0754 100644
--- a/drivers/mmc/host/sdhci_am654.c
+++ b/drivers/mmc/host/sdhci_am654.c
@@ -514,6 +514,26 @@ static const struct sdhci_am654_driver_data sdhci_j721e_4bit_drvdata = {
 	.flags = IOMUX_PRESENT,
 };
 
+static const struct sdhci_pltfm_data sdhci_am64_8bit_pdata = {
+	.ops = &sdhci_j721e_8bit_ops,
+	.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
+};
+
+static const struct sdhci_am654_driver_data sdhci_am64_8bit_drvdata = {
+	.pdata = &sdhci_am64_8bit_pdata,
+	.flags = DLL_PRESENT | DLL_CALIB,
+};
+
+static const struct sdhci_pltfm_data sdhci_am64_4bit_pdata = {
+	.ops = &sdhci_j721e_4bit_ops,
+	.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
+};
+
+static const struct sdhci_am654_driver_data sdhci_am64_4bit_drvdata = {
+	.pdata = &sdhci_am64_4bit_pdata,
+	.flags = IOMUX_PRESENT,
+};
+
 static const struct soc_device_attribute sdhci_am654_devices[] = {
 	{ .family = "AM65X",
 	  .revision = "SR1.0",
@@ -737,6 +757,14 @@ static const struct of_device_id sdhci_am654_of_match[] = {
 		.compatible = "ti,j721e-sdhci-4bit",
 		.data = &sdhci_j721e_4bit_drvdata,
 	},
+	{
+		.compatible = "ti,am64-sdhci-8bit",
+		.data = &sdhci_am64_8bit_drvdata,
+	},
+	{
+		.compatible = "ti,am64-sdhci-4bit",
+		.data = &sdhci_am64_4bit_drvdata,
+	},
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, sdhci_am654_of_match);

[PATCH 1/2] dt-bindings: mmc: sdhci-am654: Add compatible string for AM64 SoC

From: Aswath Govindraju <hidden>
Date: 2021-01-13 12:01:15

Add compatible string for AM64 SoC in device tree binding of AM654 SDHCI module
as the same IP is used.

Signed-off-by: Aswath Govindraju <redacted>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
index 1ae945434c53..34e53db29428 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
@@ -21,6 +21,8 @@ properties:
       - ti,j721e-sdhci-4bit
       - ti,j7200-sdhci-8bit
       - ti,j721e-sdhci-4bit
+      - ti,am64-sdhci-8bit
+      - ti,am64-sdhci-4bit
 
   reg:
     maxItems: 2
-- 
2.17.1

Re: [PATCH 1/2] dt-bindings: mmc: sdhci-am654: Add compatible string for AM64 SoC

From: Aswath Govindraju <hidden>
Date: 2021-01-13 12:07:25

Hi,

On 13/01/21 5:29 pm, Aswath Govindraju wrote:
Add compatible string for AM64 SoC in device tree binding of AM654 SDHCI module
as the same IP is used.

Signed-off-by: Aswath Govindraju <redacted>
Acked-by: Rob Herring <robh@kernel.org>
---
Very sorry forgot to add RESEND tag in the subject. The link to the
original patch,
https://lore.kernel.org/patchwork/patch/1361560/

Thanks,
Aswath
quoted hunk
 Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
index 1ae945434c53..34e53db29428 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
@@ -21,6 +21,8 @@ properties:
       - ti,j721e-sdhci-4bit
       - ti,j7200-sdhci-8bit
       - ti,j721e-sdhci-4bit
+      - ti,am64-sdhci-8bit
+      - ti,am64-sdhci-4bit
 
   reg:
     maxItems: 2

Re: [PATCH 0/2] mmc: AM64: Add new compatible string and driver support

From: Ulf Hansson <hidden>
Date: 2021-01-13 13:09:05

On Wed, 13 Jan 2021 at 12:59, Aswath Govindraju [off-list ref] wrote:
The following series of patches,
- Adds new compatible string for AM64 SoC
- Adds support for AM64 SoC in sdhci_am654 driver

This patch series is a combination of the patches [1] and [2].

[1] - https://lore.kernel.org/patchwork/patch/1361560/
[2] - https://lore.kernel.org/patchwork/patch/1364589/

Aswath Govindraju (1):
  dt-bindings: mmc: sdhci-am654: Add compatible string for AM64 SoC

Faiz Abbas (1):
  mmc: sdhci_am654: Add Support for TI's AM64 SoC

 .../devicetree/bindings/mmc/sdhci-am654.yaml  |  2 ++
 drivers/mmc/host/sdhci_am654.c                | 28 +++++++++++++++++++
 2 files changed, 30 insertions(+)

--
2.17.1
Applied for next, thanks!

Kind regards
Uffe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help