From: Jonathan Neuschäfer <j.neuschaefer@gmx.net> Date: 2021-01-08 16:32:06
The NPCM750 Timer/Watchdog Controller has multiple interrupt lines,
connected to multiple timers. The driver uses timer 0 for timer
interrupts, so the interrupt line corresponding to timer 0 should be
specified in DT.
I removed the mention of "flags for falling edge", because the timer
controller uses high-level interrupts rather than falling-edge
interrupts, and whether flags should be specified is up the interrupt
controller's DT binding.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
v2:
- Fix a typo in the word "watchdog"
---
.../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
@@ -6,8 +6,7 @@ timer counters. Required properties: - compatible : "nuvoton,npcm750-timer" for Poleg NPCM750. - reg : Offset and length of the register set for the device.-- interrupts : Contain the timer interrupt with flags for- falling edge.+- interrupts : Contain the timer interrupt of timer 0. - clocks : phandle of timer reference clock (usually a 25 MHz clock). Example:--
From: Avi Fishman <avifishman70@gmail.com> Date: 2021-01-10 10:21:30
On Fri, Jan 8, 2021 at 6:30 PM Jonathan Neuschäfer
[off-list ref] wrote:
The NPCM750 Timer/Watchdog Controller has multiple interrupt lines,
connected to multiple timers. The driver uses timer 0 for timer
interrupts, so the interrupt line corresponding to timer 0 should be
specified in DT.
I removed the mention of "flags for falling edge", because the timer
controller uses high-level interrupts rather than falling-edge
interrupts, and whether flags should be specified is up the interrupt
controller's DT binding.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by Avi Fishman [off-list ref]
quoted hunk
---
v2:
- Fix a typo in the word "watchdog"
---
.../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
@@ -6,8 +6,7 @@ timer counters. Required properties: - compatible : "nuvoton,npcm750-timer" for Poleg NPCM750. - reg : Offset and length of the register set for the device.-- interrupts : Contain the timer interrupt with flags for- falling edge.+- interrupts : Contain the timer interrupt of timer 0. - clocks : phandle of timer reference clock (usually a 25 MHz clock). Example:--
From: Rob Herring <robh@kernel.org> Date: 2021-01-13 15:24:47
On Fri, 08 Jan 2021 17:30:04 +0100, Jonathan Neuschäfer wrote:
The NPCM750 Timer/Watchdog Controller has multiple interrupt lines,
connected to multiple timers. The driver uses timer 0 for timer
interrupts, so the interrupt line corresponding to timer 0 should be
specified in DT.
I removed the mention of "flags for falling edge", because the timer
controller uses high-level interrupts rather than falling-edge
interrupts, and whether flags should be specified is up the interrupt
controller's DT binding.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
v2:
- Fix a typo in the word "watchdog"
---
.../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)