[PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting

Subsystems: arm/freescale imx / mxc / layerscape arm architecture, the rest

STALE2195d

3 messages, 2 authors, 2020-09-01 · open the first message on its own page

[PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting

From: Robin Gong <hidden>
Date: 2020-08-31 09:22:47

Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 use
1:1.

Signed-off-by: Robin Gong <redacted>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index cad2dd7..6038f66 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -702,7 +702,7 @@
 				reg = <0x30bd0000 0x10000>;
 				interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX8MP_CLK_SDMA1_ROOT>,
-					 <&clk IMX8MP_CLK_SDMA1_ROOT>;
+					 <&clk IMX8MP_CLK_AHB>;
 				clock-names = "ipg", "ahb";
 				#dma-cells = <3>;
 				fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
-- 
2.7.4

Re: [PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting

From: Fabio Estevam <festevam@gmail.com>
Date: 2020-08-31 11:26:09

Hi Robin,

On Mon, Aug 31, 2020 at 6:22 AM Robin Gong [off-list ref] wrote:
Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 use
1:1.

Signed-off-by: Robin Gong <redacted>
Please add a Fixes tag.

Thanks

RE: [PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting

From: Robin Gong <hidden>
Date: 2020-09-01 02:09:26

On 2020/08/31 19:12 Fabio Estevam [off-list ref] wrote: 
Hi Robin,

On Mon, Aug 31, 2020 at 6:22 AM Robin Gong [off-list ref] wrote:
quoted
Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3
use 1:1.

Signed-off-by: Robin Gong <redacted>
Please add a Fixes tag.
Resent with tags, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help