# Re: \[PATCH v2 3/6\] regulator: Add regulator driver for ATC260x PMICs

- From: Mark Brown \<broonie@kernel.org\>
- Date: 2020-08-25 10:55:54 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2020/08/6082079
- Thread: https://ratatoskr.run/linux-devicetree/2020/08/6078839/t.md

```text
On Tue, Aug 25, 2020 at 02:23:10AM +0300, Cristian Ciocaltea wrote:
> On Mon, Aug 24, 2020 at 12:00:45PM +0100, Mark Brown wrote:

> > Please write normal conditional statements to make things easier to
> > read.  It also looks like this would be more robustly written by just
> > having separate ops for DCDCs and LDOs, this could easily break if
> > another device is supported in the driver.

> Sure, I can provide separate ops, but in this case we duplicate almost
> all of them. If this is not acceptable, then I will just rewrite the
> conditional statement.

That's fine, it's just a fairly small struct that's being duplicated not
code.
```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-devicetree/2020/08/6082079/attachment/0) (application/pgp-signature, 488 bytes)