[PATCH v2] ARM: dts: vfxxx: Add syscon compatible with ocotp
Subsystems:
the rest
2225d
5 messages,
3 authors,
2020-08-21 · open the first message on its own page
From: Chris Healy <redacted>
Add syscon compatibility with Vybrid ocotp node. This is required to
access the UID.
Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")
Cc: stable@vger.kernel.org
Signed-off-by: Chris Healy <redacted>
---
Changes in v2:
- Add Fixes line to commit message
arch/arm/boot/dts/vfxxx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
index 0fe03aa0367f..2259d11af721 100644
--- a/arch/arm/boot/dts/vfxxx.dtsi
+++ b/arch/arm/boot/dts/vfxxx.dtsi @@ -495,7 +495,7 @@ edma1: dma-controller@40098000 {
};
ocotp : ocotp @ 400a5000 {
- compatible = "fsl,vf610-ocotp" ; + compatible = "fsl,vf610-ocotp" , "syscon" ; reg = < 0x400a5000 0x1000 > ;
clocks = <& clks VF610_CLK_OCOTP > ;
}; --
2.26.2
Hi Chris,
On Thu, Aug 20, 2020 at 1:11 AM Chris Healy [off-list ref] wrote:
From: Chris Healy <redacted>
Add syscon compatibility with Vybrid ocotp node. This is required to
access the UID.
Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")
Cc: stable@vger.kernel.org
Signed-off-by: Chris Healy <redacted>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
On 2020-08-20 06:10, Chris Healy wrote: From: Chris Healy <redacted>
Add syscon compatibility with Vybrid ocotp node. This is required to
access the UID.
Hm, it seems today the SoC driver uses the specific compatible. It also
should expose the UID as soc_id, see drivers/soc/imx/soc-imx.c.
Maybe it does make sense exposing it as syscon, but then we should
probably also adjust
Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt.
--
Stefan
quoted hunk
Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")
Cc: stable@vger.kernel.org
Signed-off-by: Chris Healy <redacted>
---
Changes in v2:
- Add Fixes line to commit message
arch/arm/boot/dts/vfxxx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
index 0fe03aa0367f..2259d11af721 100644
--- a/arch/arm/boot/dts/vfxxx.dtsi
+++ b/arch/arm/boot/dts/vfxxx.dtsi @@ -495,7 +495,7 @@ edma1: dma-controller@40098000 {
};
ocotp : ocotp @ 400a5000 {
- compatible = "fsl,vf610-ocotp" ; + compatible = "fsl,vf610-ocotp" , "syscon" ; reg = < 0x400a5000 0x1000 > ;
clocks = <& clks VF610_CLK_OCOTP > ;
};
On Fri, Aug 21, 2020 at 6:21 AM Stefan Agner [off-list ref] wrote:
On 2020-08-20 06:10, Chris Healy wrote: quoted From: Chris Healy <redacted>
Add syscon compatibility with Vybrid ocotp node. This is required to
access the UID.
Hm, it seems today the SoC driver uses the specific compatible. It also
should expose the UID as soc_id, see drivers/soc/imx/soc-imx.c. Yes, until I added syscon, the soc_id was empty and I would get the
following line in dmesg: "failed to find vf610-ocotp regmap!
Maybe it does make sense exposing it as syscon, but then we should
probably also adjust
Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt. Makes sense. I will update vf610-ocotp.txt in v3. Tnx
--
Stefan
quoted
Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")
Cc: stable@vger.kernel.org
Signed-off-by: Chris Healy <redacted>
---
Changes in v2:
- Add Fixes line to commit message
arch/arm/boot/dts/vfxxx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
index 0fe03aa0367f..2259d11af721 100644
--- a/arch/arm/boot/dts/vfxxx.dtsi
+++ b/arch/arm/boot/dts/vfxxx.dtsi @@ -495,7 +495,7 @@ edma1: dma-controller@40098000 {
};
ocotp : ocotp @ 400a5000 {
- compatible = "fsl,vf610-ocotp" ; + compatible = "fsl,vf610-ocotp" , "syscon" ; reg = < 0x400a5000 0x1000 > ;
clocks = <& clks VF610_CLK_OCOTP > ;
};
On 2020-08-21 16:13, Chris Healy wrote: On Fri, Aug 21, 2020 at 6:21 AM Stefan Agner [off-list ref] wrote: quoted
On 2020-08-20 06:10, Chris Healy wrote: quoted From: Chris Healy <redacted>
Add syscon compatibility with Vybrid ocotp node. This is required to
access the UID.
Hm, it seems today the SoC driver uses the specific compatible. It also
should expose the UID as soc_id, see drivers/soc/imx/soc-imx.c. Yes, until I added syscon, the soc_id was empty and I would get the
following line in dmesg: "failed to find vf610-ocotp regmap!
Ah I see, it looks up syscon, so that requires syscon to be in
compatible.
quoted Maybe it does make sense exposing it as syscon, but then we should
probably also adjust
Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt. Makes sense. I will update vf610-ocotp.txt in v3. Tnx
Ok, thx. With that you can add Reviewed-by: Stefan Agner
[off-list ref] as well.
--
Stefan
quoted --
Stefan
quoted
Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")
Cc: stable@vger.kernel.org
Signed-off-by: Chris Healy <redacted>
---
Changes in v2:
- Add Fixes line to commit message
arch/arm/boot/dts/vfxxx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
index 0fe03aa0367f..2259d11af721 100644
--- a/arch/arm/boot/dts/vfxxx.dtsi
+++ b/arch/arm/boot/dts/vfxxx.dtsi @@ -495,7 +495,7 @@ edma1: dma-controller@40098000 {
};
ocotp : ocotp @ 400a5000 {
- compatible = "fsl,vf610-ocotp" ; + compatible = "fsl,vf610-ocotp" , "syscon" ; reg = < 0x400a5000 0x1000 > ;
clocks = <& clks VF610_CLK_OCOTP > ;
};