Thread (24 messages) 24 messages, 4 authors, 2020-07-27

Re: [RFC PATCH v4 12/14] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

From: Dmitry Osipenko <digetx@gmail.com>
Date: 2020-07-27 00:10:33
Also in: linux-i2c, linux-media, linux-tegra, lkml

24.07.2020 02:51, Sowjanya Komatineni пишет:
With the split of MIPI calibration into tegra_mipi_calibrate() and
tegra_mipi_wait(), MIPI clock is not kept enabled till the calibration
is done.

So, this patch skips disabling MIPI clock after triggering start of
calibration and disables it only after waiting for done status from
the calibration logic.

This patch renames tegra_mipi_calibrate() as tegra_mipi_start_calibration()
and tegra_mipi_wait() as tegra_mipi_finish_calibration() to be inline
with their usage....
-int tegra_mipi_calibrate(struct tegra_mipi_device *device);
-int tegra_mipi_wait(struct tegra_mipi_device *device);
+int tegra_mipi_start_calibrate(struct tegra_mipi_device *device);
+int tegra_mipi_finish_calibrate(struct tegra_mipi_device *device);
+void tegra_mipi_cancel_calibrate(struct tegra_mipi_device *device);
Could you please use function names as they are named in the commit's
description? The "start_calibrate" doesn't sound like a proper English,
otherwise patch looks good to me.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help