# RE: \[PATCH v2 02/10\] net: ethernet: ixgbe: don't call devm\_mdiobus\_free()

- From: Kirsher, Jeffrey T \<hidden\>
- Date: 2020-06-29 18:59:09 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2020/06/6017553
- Thread: https://ratatoskr.run/netdev/2020/06/6018731/t.md

```text
> -----Original Message-----
> From: Bartosz Golaszewski <redacted>
> Sent: Monday, June 29, 2020 05:04
> To: Kirsher, Jeffrey T <redacted>; David S . Miller
> [ref]; Jakub Kicinski [ref]; John Crispin
> [ref]; Sean Wang [ref]; Mark Lee
> [ref]; Matthias Brugger
> [ref]; Heiner Kallweit [ref]; Andrew
> Lunn [ref]; Florian Fainelli [ref]; Russell King
> [ref]; Rob Herring [ref]; Frank Rowand
> [ref]
> Cc: <redacted>; <redacted>; linux-arm-
> kernel@lists.infradead.org; linux-mediatek@lists.infradead.org;
> devicetree@vger.kernel.org; Bartosz Golaszewski
> [ref]
> Subject: [PATCH v2 02/10] net: ethernet: ixgbe: don't call
> devm_mdiobus_free()
> 
> From: Bartosz Golaszewski <redacted>
> 
> The idea behind devres is that the release callbacks are called if probe fails. As
> we now check the return value of ixgbe_mii_bus_init(), we can drop the call
> devm_mdiobus_free() in error path as the release callback will be called
> automatically.
> 
> Signed-off-by: Bartosz Golaszewski <redacted>
 
Acked-by: Jeff Kirsher <redacted>

> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
```
