# Re: \[PATCH RFC\] Bindings: nvmem: add bindings for JZ4780 efuse

- From: Andreas Kemnade \<andreas@kemnade.info\>
- Date: 2020-02-24 06:48:58 
- List: linux-devicetree
- Page: https://ratatoskr.run/linux-devicetree/2020/02/5872785
- Thread: https://ratatoskr.run/linux-devicetree/2020/02/5865370/t.md

```text
On Thu, 20 Feb 2020 13:53:55 -0600
Rob Herring [ref] wrote:

[...]
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clock  
> 
> 'make dt_binding_check' would have pointed the error here for you:
> 
I did run make dt_binding_check...
It stopped because the jz4780-cgu.h included was missing. Then I have added
that line and have started dt_binding_check again.
At least here it is doing a full rerun in the second part.
After some time I scrolled back and noticed DTC passed
and missed that

> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.example.dt.yaml:
> efuse@134100d0: 'clock' is a required property
> 
in the CHECKS line. Well, dt_binding_check is a bit noisy. I guess I should
have redirected all output to a text file, before and after my changes. and
diffed the results. 
Is there any script ready for that?

Regards,
Andreas
```

## Attachments

- [(unnamed)](https://ratatoskr.run/linux-devicetree/2020/02/5872785/attachment/0) (application/pgp-signature, 833 bytes)