Re: [PATCH v2 1/3] dt-bindings: interrupt-controller: Actions external interrupt controller
From: Rob Herring <robh@kernel.org>
Date: 2018-08-13 19:44:58
Also in:
linux-arm-kernel, lkml
On Sun, Aug 12, 2018 at 02:22:13PM +0200, Parthiban Nallathambi wrote:
quoted hunk ↗ jump to hunk
Actions Semi OWL family SoC's provides support for external interrupt controller to be connected and controlled using SIRQ pins. S500, S700 and S900 provides 3 SIRQ lines and works independently for 3 external interrupt controllers. Signed-off-by: Parthiban Nallathambi <redacted> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com> --- .../interrupt-controller/actions,owl-sirq.txt | 46 ++++++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txtdiff --git a/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt b/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt new file mode 100644 index 000000000000..4b8437751331 --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.txt@@ -0,0 +1,46 @@ +Actions Semi Owl SoCs SIRQ interrupt controller + +S500, S700 and S900 SoC's from Actions provides 3 SPI's from GIC, +in which external interrupt controller can be connected. 3 SPI's +45, 46, 47 from GIC are directly exposed as SIRQ. It has +the following properties: + +- inputs three interrupt signal from external interrupt controller + +Required properties: + +- compatible: should be "actions,owl-sirq" +- reg: physical base address of the controller and length of memory mapped. +- interrupt-controller: identifies the node as an interrupt controller +- #interrupt-cells: specifies the number of cells needed to encode an interrupt + source, should be 2.
+- actions,sirq-shared-reg: Applicable for S500 and S700 where SIRQ register + details are maintained at same offset/register. +- actions,sirq-offset: register offset for SIRQ interrupts. When registers are + shared, all the three offsets will be same (S500 and S700).
You should have more specific compatible strings if there are differences and these settings can be implied by them.
+- actions,sirq-clk-sel: external interrupt controller can be either + connected to 32Khz or 24Mhz external/internal clock. This needs + to be configured for per SIRQ line. Failing defaults to 32Khz clock.
What are the valid values?
+
+Example for S900:
+
+sirq: interrupt-controller@e01b0000 {
+ compatible = "actions,owl-sirq";
+ reg = <0 0xe01b0000 0 0x1000>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ actions,sirq-clk-sel = <0 0 0>;If 0 is 32khz, then having this is pointless. But I can't tell what the values correspond to.
+ actions,sirq-offset = <0x200 0x528 0x52c>;
+};
+
+Example for S500 and S700:
+
+sirq: interrupt-controller@e01b0000 {
+ compatible = "actions,owl-sirq";
+ reg = <0 0xe01b0000 0 0x1000>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ actions,sirq-shared-reg;
+ actions,sirq-clk-sel = <0 0 0>;
+ actions,sirq-offset = <0x200 0x200 0x200>;
+};
--
2.14.4