Thread (11 messages) 11 messages, 4 authors, 2018-03-18
STALE3005d

[PATCH] ASoC: fix boolreturn.cocci warnings

From: kbuild test robot <hidden>
Date: 2018-03-02 22:48:48
Also in: alsa-devel, lkml

From: Fengguang Wu <redacted>

sound/soc/codecs/tda7419.c:151:9-10: WARNING: return of 0/1 in function 'tda7419_vol_is_stereo' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: d811df0fabec ("ASoC: add tda7419 audio processor driver")
CC: Matt Porter <redacted>
Signed-off-by: Fengguang Wu <redacted>
---

 tda7419.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--- a/sound/soc/codecs/tda7419.c
+++ b/sound/soc/codecs/tda7419.c
@@ -148,9 +148,9 @@ struct tda7419_vol_control {
 static inline bool tda7419_vol_is_stereo(struct tda7419_vol_control *tvc)
 {
 	if (tvc->reg == tvc->rreg)
-		return 0;
+		return false;
 
-	return 1;
+	return true;
 }
 
 static int tda7419_vol_info(struct snd_kcontrol *kcontrol,
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help