From: Sean Wang <sean.wang@mediatek.com>
The series is to refactor current .dts for allowing more boards can properly
join and reuse almost the same device node definitions.
Before we're doing that, some works about enhancements and fixups are being
made on the dt-binding document and .dts files. In addition, the series has to
depend on the patch [1][2]. Otherwise, certain build failure would have an
occurrence.
[1] arm: dts: mt7623: add PCIe related nodes
http://lists.infradead.org/pipermail/linux-mediatek/2018-February/012053.html
[2] dt-bindings: soc: add header files required for MT7623A SCPSYS dt-binding
http://lists.infradead.org/pipermail/linux-mediatek/2018-February/011930.html
Sean Wang (19):
dt-bindings: pinctrl: mediatek: use - instead of _ in examples
dt-bindings: cpufreq: mediatek: use - instead of _ in examples
dt-bindings: pinctrl: mediatek: add bindings for I2C2 and SPI2 on
MT7623
dt-bindings: arm: mediatek: add support for more mt7623 reference
boards
arm: dts: mt7623: add BTIF, HSDMA and SPI-NOR device nodes
arm: dts: mt7623: fix USB initialization fails on bananapi-r2
arm: dts: mt7623: fix the regulators mmc should use on bananapi-r2
arm: dts: mt7623: enable three available UARTs on bananapi-r2
arm: dts: mt7623: add related clock properties to cpu[1-3] nodes
arm: dts: mt7623: remove useless property pinctrl-names at node
switch@0
arm: dts: mt7623: use - instead of _ in DT node name
arm: dts: mt7623: fix all Warnings (unit_address_vs_reg)
arm: dts: mt7623: move node mt6323 leds to mt6323.dtsi
arm: dts: mt7623: extend common file to unify all boards with MT7623
SoCs
arm: dts: mt7623: add SPI[1,2], I2C2 and sound related nodes to
reference board
arm: dts: mt7623: fixup available memory size on bananapi-r2
arm: dts: mt7623: add MT7623N reference board with eMMC
arm: dts: mt7623: add MT7623A reference boards
arm: dts: mediatek: converted to using SPDX identifiers
Documentation/devicetree/bindings/arm/mediatek.txt | 9 +
.../bindings/cpufreq/cpufreq-mediatek.txt | 6 +-
.../devicetree/bindings/pinctrl/pinctrl-mt65xx.txt | 4 +-
arch/arm/boot/dts/Makefile | 3 +
arch/arm/boot/dts/mt2701-evb.dts | 9 +-
arch/arm/boot/dts/mt2701.dtsi | 9 +-
arch/arm/boot/dts/mt6323.dtsi | 34 +-
arch/arm/boot/dts/mt6580-evbp1.dts | 9 +-
arch/arm/boot/dts/mt6580.dtsi | 9 +-
arch/arm/boot/dts/mt6589-aquaris5.dts | 10 +-
arch/arm/boot/dts/mt6589.dtsi | 12 +-
arch/arm/boot/dts/mt6592-evb.dts | 9 +-
arch/arm/boot/dts/mt6592.dtsi | 9 +-
arch/arm/boot/dts/mt7623.dtsi | 70 ++-
arch/arm/boot/dts/mt7623a-rfb-emmc.dts | 22 +
arch/arm/boot/dts/mt7623a-rfb-nand.dts | 26 +
arch/arm/boot/dts/mt7623a-rfb.dtsi | 84 +++
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 462 +--------------
arch/arm/boot/dts/mt7623n-rfb-emmc.dts | 37 ++
arch/arm/boot/dts/mt7623n-rfb-nand.dts | 100 +---
arch/arm/boot/dts/mt7623n-rfb.dtsi | 652 ++++++++++++++++++++-
arch/arm/boot/dts/mt8127-moose.dts | 9 +-
arch/arm/boot/dts/mt8127.dtsi | 9 +-
arch/arm/boot/dts/mt8135-evbp1.dts | 9 +-
arch/arm/boot/dts/mt8135.dtsi | 9 +-
include/dt-bindings/pinctrl/mt7623-pinfunc.h | 24 +
26 files changed, 966 insertions(+), 679 deletions(-)
create mode 100644 arch/arm/boot/dts/mt7623a-rfb-emmc.dts
create mode 100644 arch/arm/boot/dts/mt7623a-rfb-nand.dts
create mode 100644 arch/arm/boot/dts/mt7623a-rfb.dtsi
create mode 100644 arch/arm/boot/dts/mt7623n-rfb-emmc.dts
--
2.7.4
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
It should be good that no use "_" is in examples. Consequently,
those nodes in certain files which have an inappropriate name containing
"_" are all being replaced with "-".
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: "Rafael J. Wysocki" <redacted>
Cc: Viresh Kumar <redacted>
Cc: Rob Herring <redacted>
Cc: Mark Rutland <redacted>
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Add missing pinctrl binding about I2C2 and SPI2 which would be used in
devicetree related files.
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Rob Herring <redacted>
Cc: Mark Rutland <redacted>
Cc: Linus Walleij <redacted>
Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
include/dt-bindings/pinctrl/mt7623-pinfunc.h | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
From: Sean Wang <sean.wang@mediatek.com>
Update binding document for more mt7623[A,N] reference boards being
supported.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org
---
Documentation/devicetree/bindings/arm/mediatek.txt | 9 +++++++++
1 file changed, 9 insertions(+)
From: Sean Wang <sean.wang@mediatek.com>
add BTIF, HSDMA and SPI-NOR device nodes and enable it on relevant boards
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/mt7623.dtsi | 36 ++++++++++++++++++++++++++-
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 6 ++++-
2 files changed, 40 insertions(+), 2 deletions(-)
From: Sean Wang <sean.wang@mediatek.com>
Since those LEDs are parts of PMIC MT6323, it is reasonable to merge
those LEDs node definition back into mt6323.dtsi. This way can improve
the reusability of those nodes among different boards with the same PMIC.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Lee Jones <redacted>
---
arch/arm/boot/dts/mt6323.dtsi | 26 ++++++++++++++++++++++++-
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 28 ---------------------------
2 files changed, 25 insertions(+), 29 deletions(-)
From: Sean Wang <sean.wang@mediatek.com>
In fact, bananapi-r2 board is derived and customized from the official
MT7623N reference board with eMMC.
In order to introduce more boards such as official MT7623A reference
boards to current devicetree without copy-n-pasting the almost same
content of nodes into every new file, it's better to reuse those nodes
by consolidating them into common files mt7623n-rfb.dtsi from
mt7623n-bananapi-bpi-r2.dts and allow existing or new .dts files to refer
to them.
After grouping those common nodes into mt7623n-rfb.dtsi, it becomes more
simple to know what differences are between each board from terminal .dts
such that bananapi-r2 uses eMMC as the primary storage, has the dedicated
GPIO LEDs, and I2C1 working through pin 57 and 58 as the pin-usage,
enables the second USB slot and owns its definition for each switch port
against the existing mt7623n-rfb-nand.dts.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 467 +--------------------
arch/arm/boot/dts/mt7623n-rfb-nand.dts | 91 +---
arch/arm/boot/dts/mt7623n-rfb.dtsi | 570 +++++++++++++++++++++++++-
3 files changed, 575 insertions(+), 553 deletions(-)
From: Sean Wang <sean.wang@mediatek.com>
Complement the missing clock properties cpu[1-3] should depend on.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: "Rafael J. Wysocki" <redacted>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org
---
arch/arm/boot/dts/mt7623.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
From: Sean Wang <sean.wang@mediatek.com>
Add MT7623N reference board with eMMC. On the board, there is additional
external PHY which is ICPlus IP1001 transceiver available by port 5 on the
MDIO bus connectted with GMAC2.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/mt7623n-rfb-emmc.dts | 37 ++++++++++++++++++++++++++++++++++
2 files changed, 38 insertions(+)
create mode 100644 arch/arm/boot/dts/mt7623n-rfb-emmc.dts
From: Sean Wang <sean.wang@mediatek.com>
It should be good that no use "_" is in DT node name. Consequently,
those nodes in certain files which have an inappropriate name containing
"_" are all being replaced with "-".
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org
---
arch/arm/boot/dts/mt7623.dtsi | 12 +++----
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 50 +++++++++++++--------------
arch/arm/boot/dts/mt7623n-rfb-nand.dts | 6 ++--
3 files changed, 34 insertions(+), 34 deletions(-)
From: Sean Wang <sean.wang@mediatek.com>
The property pinctrl-names is totally superfluous. It would be good to
remove the property to keep the node neatness. There is actually
unnecessary to set up any pins for data path TRGMII between main SoC and
MT7530. Furthermore, it's more reasonable for the pin setup of control
path MDIO bus is being placed inside the node of ethernet controller.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 1 -
1 file changed, 1 deletion(-)
From: Sean Wang <sean.wang@mediatek.com>
There are SPI[1,2] and I2C2 and sound device with WM8960 codec which
MT7623 reference board is equipped with.
However, some of those devices cannot be found on bananapi-r2, they should
be disabled properly for that.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 16 ++++++++
arch/arm/boot/dts/mt7623n-rfb.dtsi | 58 +++++++++++++++++++++++++++
2 files changed, 74 insertions(+)
From: Sean Wang <sean.wang@mediatek.com>
Fix below a lot of warnings that dtc complains so much
Warning (unit_address_vs_reg): Node /oscillator@1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /oscillator@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/cir@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/i2c@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/i2c@1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/i2s@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/i2s@1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/keys@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/leds@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/pwm@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/spi@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/uart@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/uart@1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/uart@2 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /ethernet@1b100000/mdio-bus/switch@0/ports has a reg or ranges property, but no unit name
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org
---
arch/arm/boot/dts/mt7623.dtsi | 4 ++--
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 29 +++++++++++++--------------
arch/arm/boot/dts/mt7623n-rfb.dtsi | 2 +-
3 files changed, 17 insertions(+), 18 deletions(-)
From: Sean Wang <sean.wang@mediatek.com>
Add mt7623a-rfb.dtsi where most nodes can be inherited from
mt7623n-rfb.dtsi and keep these distinctions from MT7623A boards in
mt7623a-rfb.dtsi for most definition can be reused among MT7623A board
variants.
MT7623A has its specific definition of power domain and thus we need
to change related devices such as audio, ethernet, crypto, high-speed
DMA, NAND, and USB controller to the power domain they specifically
belong to. In addition, MT7530 exists as built-in module inside MT7623A
SoC and I2C2 and UART[0-1] get being removed and UART2 have distinct pin
usage. Those all differences can be totally seen in mt7623a-rfb.dtsi.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/Makefile | 2 +
arch/arm/boot/dts/mt7623a-rfb-emmc.dts | 22 +++++++++
arch/arm/boot/dts/mt7623a-rfb-nand.dts | 26 +++++++++++
arch/arm/boot/dts/mt7623a-rfb.dtsi | 84 ++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/mt7623n-rfb.dtsi | 15 ++++++
5 files changed, 149 insertions(+)
create mode 100644 arch/arm/boot/dts/mt7623a-rfb-emmc.dts
create mode 100644 arch/arm/boot/dts/mt7623a-rfb-nand.dts
create mode 100644 arch/arm/boot/dts/mt7623a-rfb.dtsi
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Fix that USB initialization fails as below runtime log is present during
booting on bananapi-r2 board by adding missing regulators the USB device
requires. Current regulators USB device uses are being updated with the
correct ones to reflect real configurations which are all from fixed
regulators rather than MT6323 one's output.
[ 6.473958] xhci-mtk 1a1c0000.usb: fail to get vbus
[ 6.479313] xhci-mtk 1a240000.usb: fail to get vbus
Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Fixes: f4ff257cd160 ("arm: dts: mt7623: add support for Bananapi R2 (BPI-R2) board")
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 24 ++++++++++++++++++++++--
1 file changed, 22 insertions(+), 2 deletions(-)
From: Sean Wang <sean.wang@mediatek.com>
There is 2GB DDR3 available on bananapi-r2 board as [1] specified.
[1] http://www.banana-pi.org/r2.html
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 5 +++++
1 file changed, 5 insertions(+)
From: Sean Wang <sean.wang@mediatek.com>
Both mmc devices on bananapi-r2 board should all use the fixed regulators
as their power source instead of PMIC MT6323 exports.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
It should be good that no use "_" is in examples. Consequently,
those nodes in certain files which have an inappropriate name containing
"_" are all being replaced with "-".
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Linus Walleij <redacted>
Cc: Rob Herring <redacted>
Cc: Mark Rutland <redacted>
Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Sean Wang <sean.wang@mediatek.com>
On bpi-r2 board, totally there're four UARTs which we usually called
uart[0-3] helpful to extend slow-I/O devices. Among those ones, uart2 has
dedicated pin slot which is used to console log. uart[0-1] appear at the
40-pins connector and uart3 has no pinout, but just has test points (TP47
for TX and TP48 for RX, respectively) nearby uart2, but we don't enable
uart3 in the patch. The missing pinctrl is also being supplemented for
those newly added devices.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
From: Sean Wang <sean.wang@mediatek.com>
Complement the missing clock properties cpu[1-3] should depend on.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: "Rafael J. Wysocki" <redacted>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org
---
arch/arm/boot/dts/mt7623.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
From: Sean Wang <sean.wang@mediatek.com>
It should be good that no use "_" is in examples. Consequently,
those nodes in certain files which have an inappropriate name containing
"_" are all being replaced with "-".
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: "Rafael J. Wysocki" <redacted>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-pm@vger.kernel.org
Cc: devicetree@vger.kernel.org
---
Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
On Fri, Feb 23, 2018 at 11:16 AM, [off-list ref] wrote:
From: Sean Wang <sean.wang@mediatek.com>
It should be good that no use "_" is in examples. Consequently,
those nodes in certain files which have an inappropriate name containing
"_" are all being replaced with "-".
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Linus Walleij <redacted>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-gpio@vger.kernel.org
Cc: devicetree@vger.kernel.org
On Fri, Feb 23, 2018 at 11:16 AM, [off-list ref] wrote:
From: Sean Wang <sean.wang@mediatek.com>
Add missing pinctrl binding about I2C2 and SPI2 which would be used in
devicetree related files.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Linus Walleij <redacted>
Cc: linux-gpio@vger.kernel.org
Cc: devicetree@vger.kernel.org
From: Rob Herring <robh@kernel.org> Date: 2018-03-02 15:40:55
On Fri, Feb 23, 2018 at 06:16:33PM +0800, sean.wang@mediatek.com wrote:
quoted hunk
From: Sean Wang <sean.wang@mediatek.com>
Since those LEDs are parts of PMIC MT6323, it is reasonable to merge
those LEDs node definition back into mt6323.dtsi. This way can improve
the reusability of those nodes among different boards with the same PMIC.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Lee Jones <redacted>
---
arch/arm/boot/dts/mt6323.dtsi | 26 ++++++++++++++++++++++++-
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 28 ---------------------------
2 files changed, 25 insertions(+), 29 deletions(-)
Changing the label potentially breaks userspace. And the fact that it is
a green LED is very much board specific. So I think the old location was
correct. You could put the parent node here and leave these child nodes
in the board specific dts file.
From: Rob Herring <robh@kernel.org> Date: 2018-03-02 15:42:20
On Fri, Feb 23, 2018 at 06:16:36PM +0800, sean.wang@mediatek.com wrote:
quoted hunk
From: Sean Wang <sean.wang@mediatek.com>
There is 2GB DDR3 available on bananapi-r2 board as [1] specified.
[1] http://www.banana-pi.org/r2.html
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 5 +++++
1 file changed, 5 insertions(+)
From: Rob Herring <robh@kernel.org> Date: 2018-03-02 15:45:55
On Fri, Feb 23, 2018 at 06:16:38PM +0800, sean.wang@mediatek.com wrote:
quoted hunk
From: Sean Wang <sean.wang@mediatek.com>
Add mt7623a-rfb.dtsi where most nodes can be inherited from
mt7623n-rfb.dtsi and keep these distinctions from MT7623A boards in
mt7623a-rfb.dtsi for most definition can be reused among MT7623A board
variants.
MT7623A has its specific definition of power domain and thus we need
to change related devices such as audio, ethernet, crypto, high-speed
DMA, NAND, and USB controller to the power domain they specifically
belong to. In addition, MT7530 exists as built-in module inside MT7623A
SoC and I2C2 and UART[0-1] get being removed and UART2 have distinct pin
usage. Those all differences can be totally seen in mt7623a-rfb.dtsi.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/Makefile | 2 +
arch/arm/boot/dts/mt7623a-rfb-emmc.dts | 22 +++++++++
arch/arm/boot/dts/mt7623a-rfb-nand.dts | 26 +++++++++++
arch/arm/boot/dts/mt7623a-rfb.dtsi | 84 ++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/mt7623n-rfb.dtsi | 15 ++++++
5 files changed, 149 insertions(+)
create mode 100644 arch/arm/boot/dts/mt7623a-rfb-emmc.dts
create mode 100644 arch/arm/boot/dts/mt7623a-rfb-nand.dts
create mode 100644 arch/arm/boot/dts/mt7623a-rfb.dtsi
- *- * This program is distributed in the hope that it will be useful,- * but WITHOUT ANY WARRANTY; without even the implied warranty of- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the- * GNU General Public License for more details. */ /dts-v1/;
- *- * This program is distributed in the hope that it will be useful,- * but WITHOUT ANY WARRANTY; without even the implied warranty of- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the- * GNU General Public License for more details.- */+*/ #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/interrupt-controller/arm-gic.h>
@@ -1,7 +1,7 @@+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
This probably can't really be MIT because other files included are GPL
only and this file is not too useful on its own. But as copyright
holder, you could change it (that should be a separate commit).
quoted hunk
/* * Copyright 2017-2018 Sean Wang <sean.wang@mediatek.com> *- * SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ /dts-v1/;
From: Rob Herring <robh@kernel.org> Date: 2018-03-02 15:53:24
On Fri, Feb 23, 2018 at 06:16:22PM +0800, sean.wang@mediatek.com wrote:
From: Sean Wang <sean.wang@mediatek.com>
It should be good that no use "_" is in examples. Consequently,
those nodes in certain files which have an inappropriate name containing
"_" are all being replaced with "-".
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: "Rafael J. Wysocki" <redacted>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-pm@vger.kernel.org
Cc: devicetree@vger.kernel.org
---
Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From: Rob Herring <robh@kernel.org> Date: 2018-03-02 16:00:26
On Fri, Feb 23, 2018 at 06:16:24PM +0800, sean.wang@mediatek.com wrote:
From: Sean Wang <sean.wang@mediatek.com>
Update binding document for more mt7623[A,N] reference boards being
supported.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org
---
Documentation/devicetree/bindings/arm/mediatek.txt | 9 +++++++++
1 file changed, 9 insertions(+)
From: Sean Wang <sean.wang@mediatek.com> Date: 2018-03-02 22:47:08
On Fri, 2018-03-02 at 09:40 -0600, Rob Herring wrote:
On Fri, Feb 23, 2018 at 06:16:33PM +0800, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
Since those LEDs are parts of PMIC MT6323, it is reasonable to merge
those LEDs node definition back into mt6323.dtsi. This way can improve
the reusability of those nodes among different boards with the same PMIC.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Lee Jones <redacted>
---
arch/arm/boot/dts/mt6323.dtsi | 26 ++++++++++++++++++++++++-
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 28 ---------------------------
2 files changed, 25 insertions(+), 29 deletions(-)
Changing the label potentially breaks userspace. And the fact that it is
a green LED is very much board specific. So I think the old location was
correct. You could put the parent node here and leave these child nodes
in the board specific dts file.
yes, I really made a mistake on breaking userspace with a label change.
I will keep the parent node here and then leave these child nodes into
board specific dts files. thanks for your idea!
From: Sean Wang <sean.wang@mediatek.com> Date: 2018-03-02 23:27:16
On Fri, 2018-03-02 at 09:42 -0600, Rob Herring wrote:
On Fri, Feb 23, 2018 at 06:16:36PM +0800, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
There is 2GB DDR3 available on bananapi-r2 board as [1] specified.
[1] http://www.banana-pi.org/r2.html
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 5 +++++
1 file changed, 5 insertions(+)
If I did it with adding unit address
- memory {
+ memory@80000000 {
device_type = "memory";
reg = <0 0x80000000 0 0x80000000>;
};
bad dtc blob is being generated and contains two memory nodes, one is
memory and the other is memory@80000000 whose blob disassembly detail is
as the following.
memory {
device_type = "memory";
reg = <0x0 0x0 0x0 0x0>;
};
memory@80000000 {
device_type = "memory";
reg = <0x0 0x80000000 0x0 0x80000000>;
};
and bad memory node with size 0 would cause the boot fails.
is it a dtc compiler problem ?
From: Sean Wang <sean.wang@mediatek.com> Date: 2018-03-03 02:15:54
On Fri, 2018-03-02 at 09:45 -0600, Rob Herring wrote:
On Fri, Feb 23, 2018 at 06:16:38PM +0800, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
Add mt7623a-rfb.dtsi where most nodes can be inherited from
mt7623n-rfb.dtsi and keep these distinctions from MT7623A boards in
mt7623a-rfb.dtsi for most definition can be reused among MT7623A board
variants.
MT7623A has its specific definition of power domain and thus we need
to change related devices such as audio, ethernet, crypto, high-speed
DMA, NAND, and USB controller to the power domain they specifically
belong to. In addition, MT7530 exists as built-in module inside MT7623A
SoC and I2C2 and UART[0-1] get being removed and UART2 have distinct pin
usage. Those all differences can be totally seen in mt7623a-rfb.dtsi.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/Makefile | 2 +
arch/arm/boot/dts/mt7623a-rfb-emmc.dts | 22 +++++++++
arch/arm/boot/dts/mt7623a-rfb-nand.dts | 26 +++++++++++
arch/arm/boot/dts/mt7623a-rfb.dtsi | 84 ++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/mt7623n-rfb.dtsi | 15 ++++++
5 files changed, 149 insertions(+)
create mode 100644 arch/arm/boot/dts/mt7623a-rfb-emmc.dts
create mode 100644 arch/arm/boot/dts/mt7623a-rfb-nand.dts
create mode 100644 arch/arm/boot/dts/mt7623a-rfb.dtsi
Use stdout-path instead. earlyprintk option only works for a kernel
built with a debug uart at a fixed address, so drop it.
thanks, I will try and have stdout-path instead.
But for earlyprintk, our kernel can support and be built with a debug
uart at a fixed address and it is greatly useful to know what's going
on when a system hang happens on certain device's initialization prior
to uart initialization such as PCI device.
Thus, I consider to keep it there in special on such kinds of
development boards for debugging purpose.
From: Rob Herring <robh@kernel.org> Date: 2018-03-05 14:11:23
On Fri, Mar 2, 2018 at 8:15 PM, Sean Wang [off-list ref] wrote:
On Fri, 2018-03-02 at 09:45 -0600, Rob Herring wrote:
quoted
On Fri, Feb 23, 2018 at 06:16:38PM +0800, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
Add mt7623a-rfb.dtsi where most nodes can be inherited from
mt7623n-rfb.dtsi and keep these distinctions from MT7623A boards in
mt7623a-rfb.dtsi for most definition can be reused among MT7623A board
variants.
MT7623A has its specific definition of power domain and thus we need
to change related devices such as audio, ethernet, crypto, high-speed
DMA, NAND, and USB controller to the power domain they specifically
belong to. In addition, MT7530 exists as built-in module inside MT7623A
SoC and I2C2 and UART[0-1] get being removed and UART2 have distinct pin
usage. Those all differences can be totally seen in mt7623a-rfb.dtsi.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/Makefile | 2 +
arch/arm/boot/dts/mt7623a-rfb-emmc.dts | 22 +++++++++
arch/arm/boot/dts/mt7623a-rfb-nand.dts | 26 +++++++++++
arch/arm/boot/dts/mt7623a-rfb.dtsi | 84 ++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/mt7623n-rfb.dtsi | 15 ++++++
5 files changed, 149 insertions(+)
create mode 100644 arch/arm/boot/dts/mt7623a-rfb-emmc.dts
create mode 100644 arch/arm/boot/dts/mt7623a-rfb-nand.dts
create mode 100644 arch/arm/boot/dts/mt7623a-rfb.dtsi
Use stdout-path instead. earlyprintk option only works for a kernel
built with a debug uart at a fixed address, so drop it.
thanks, I will try and have stdout-path instead.
But for earlyprintk, our kernel can support and be built with a debug
uart at a fixed address and it is greatly useful to know what's going
on when a system hang happens on certain device's initialization prior
to uart initialization such as PCI device.
These days, you only need earlyprintk for *really* early console like
in the assembly boot entry code and before the DT is unflattened. For
anything else, use earlycon instead because earlycon is a runtime
option.
Thus, I consider to keep it there in special on such kinds of
development boards for debugging purpose.
Then add this option when you are doing debug. But for what's
"shipped" in mainline, you should not have this enabled.
Rob
From: Rob Herring <robh@kernel.org> Date: 2018-03-05 14:17:04
On Fri, Mar 2, 2018 at 5:27 PM, Sean Wang [off-list ref] wrote:
On Fri, 2018-03-02 at 09:42 -0600, Rob Herring wrote:
quoted
On Fri, Feb 23, 2018 at 06:16:36PM +0800, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
There is 2GB DDR3 available on bananapi-r2 board as [1] specified.
[1] http://www.banana-pi.org/r2.html
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 5 +++++
1 file changed, 5 insertions(+)
If I did it with adding unit address
- memory {
+ memory@80000000 {
device_type = "memory";
reg = <0 0x80000000 0 0x80000000>;
};
bad dtc blob is being generated and contains two memory nodes, one is
memory and the other is memory@80000000 whose blob disassembly detail is
as the following.
memory {
device_type = "memory";
reg = <0x0 0x0 0x0 0x0>;
};
memory@80000000 {
device_type = "memory";
reg = <0x0 0x80000000 0x0 0x80000000>;
};
and bad memory node with size 0 would cause the boot fails.
is it a dtc compiler problem ?
No, you are declaring "memory" node somewhere else. Perhaps using
skeleton.dtsi which we are trying to remove or you have some default.
Using just 'memory' is fine if the base address is variable and
determined at boot time or you have a bootloader that expects just
'memory'. Otherwise, this should be fixed, but you can do that after
this patch if you want.
Rob
From: Sean Wang <sean.wang@mediatek.com> Date: 2018-03-05 15:11:03
On Mon, 2018-03-05 at 08:10 -0600, Rob Herring wrote:
On Fri, Mar 2, 2018 at 8:15 PM, Sean Wang [off-list ref] wrote:
quoted
On Fri, 2018-03-02 at 09:45 -0600, Rob Herring wrote:
quoted
On Fri, Feb 23, 2018 at 06:16:38PM +0800, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
Add mt7623a-rfb.dtsi where most nodes can be inherited from
mt7623n-rfb.dtsi and keep these distinctions from MT7623A boards in
mt7623a-rfb.dtsi for most definition can be reused among MT7623A board
variants.
MT7623A has its specific definition of power domain and thus we need
to change related devices such as audio, ethernet, crypto, high-speed
DMA, NAND, and USB controller to the power domain they specifically
belong to. In addition, MT7530 exists as built-in module inside MT7623A
SoC and I2C2 and UART[0-1] get being removed and UART2 have distinct pin
usage. Those all differences can be totally seen in mt7623a-rfb.dtsi.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/Makefile | 2 +
arch/arm/boot/dts/mt7623a-rfb-emmc.dts | 22 +++++++++
arch/arm/boot/dts/mt7623a-rfb-nand.dts | 26 +++++++++++
arch/arm/boot/dts/mt7623a-rfb.dtsi | 84 ++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/mt7623n-rfb.dtsi | 15 ++++++
5 files changed, 149 insertions(+)
create mode 100644 arch/arm/boot/dts/mt7623a-rfb-emmc.dts
create mode 100644 arch/arm/boot/dts/mt7623a-rfb-nand.dts
create mode 100644 arch/arm/boot/dts/mt7623a-rfb.dtsi
Use stdout-path instead. earlyprintk option only works for a kernel
built with a debug uart at a fixed address, so drop it.
thanks, I will try and have stdout-path instead.
But for earlyprintk, our kernel can support and be built with a debug
uart at a fixed address and it is greatly useful to know what's going
on when a system hang happens on certain device's initialization prior
to uart initialization such as PCI device.
These days, you only need earlyprintk for *really* early console like
in the assembly boot entry code and before the DT is unflattened. For
anything else, use earlycon instead because earlycon is a runtime
option.
quoted
Thus, I consider to keep it there in special on such kinds of
development boards for debugging purpose.
Then add this option when you are doing debug. But for what's
"shipped" in mainline, you should not have this enabled.
Rob
Okay, for these reasons, I will remove earlyprintk usage here
and try to use earlycon instead in the future.
Really thanks for your detailed explanation!
Sean
From: Sean Wang <sean.wang@mediatek.com> Date: 2018-03-05 15:46:55
On Mon, 2018-03-05 at 08:16 -0600, Rob Herring wrote:
On Fri, Mar 2, 2018 at 5:27 PM, Sean Wang [off-list ref] wrote:
quoted
On Fri, 2018-03-02 at 09:42 -0600, Rob Herring wrote:
quoted
On Fri, Feb 23, 2018 at 06:16:36PM +0800, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
There is 2GB DDR3 available on bananapi-r2 board as [1] specified.
[1] http://www.banana-pi.org/r2.html
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 5 +++++
1 file changed, 5 insertions(+)
If I did it with adding unit address
- memory {
+ memory@80000000 {
device_type = "memory";
reg = <0 0x80000000 0 0x80000000>;
};
bad dtc blob is being generated and contains two memory nodes, one is
memory and the other is memory@80000000 whose blob disassembly detail is
as the following.
memory {
device_type = "memory";
reg = <0x0 0x0 0x0 0x0>;
};
memory@80000000 {
device_type = "memory";
reg = <0x0 0x80000000 0x0 0x80000000>;
};
and bad memory node with size 0 would cause the boot fails.
is it a dtc compiler problem ?
No, you are declaring "memory" node somewhere else. Perhaps using
skeleton.dtsi which we are trying to remove or you have some default.
Yes, your guess is right. the DTS explicitly includes skeleton64.dtsi so
two memory node is being generated.
Using just 'memory' is fine if the base address is variable and
determined at boot time or you have a bootloader that expects just
'memory'. Otherwise, this should be fixed, but you can do that after
this patch if you want.
The address where memory is located at is fixed so I should insert a
patch removing skeleton64.dtsi before adding a unit address to each
memory node.
Furthermore, the original DTS including skeleton64.dtsi seems to be a
little improper as CPU uses 32-bit addressing way to access all hardware
devices on MT7623 SoC. Thus, it seems to be better even necessary to
explicitly set both #address-cells and #size-cells to 1 at the root node
and change reg property for following the child nodes when
skeleton64.dtsi is being removed.
On Fri, Feb 23, 2018 at 06:16:24PM +0800, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
Update binding document for more mt7623[A,N] reference boards being
supported.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org
---
Documentation/devicetree/bindings/arm/mediatek.txt | 9 +++++++++
1 file changed, 9 insertions(+)
On 02/23/2018 11:16 AM, sean.wang@mediatek.com wrote:
From: Sean Wang <sean.wang@mediatek.com>
Fix that USB initialization fails as below runtime log is present during
booting on bananapi-r2 board by adding missing regulators the USB device
requires. Current regulators USB device uses are being updated with the
correct ones to reflect real configurations which are all from fixed
regulators rather than MT6323 one's output.
[ 6.473958] xhci-mtk 1a1c0000.usb: fail to get vbus
[ 6.479313] xhci-mtk 1a240000.usb: fail to get vbus
Cc: stable@vger.kernel.org
Fixes: f4ff257cd160 ("arm: dts: mt7623: add support for Bananapi R2 (BPI-R2) board")
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 24 ++++++++++++++++++++++--
1 file changed, 22 insertions(+), 2 deletions(-)
On 02/23/2018 11:16 AM, sean.wang@mediatek.com wrote:
quoted hunk
From: Sean Wang <sean.wang@mediatek.com>
Fix below a lot of warnings that dtc complains so much
Warning (unit_address_vs_reg): Node /oscillator@1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /oscillator@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/cir@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/i2c@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/i2c@1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/i2s@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/i2s@1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/keys@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/leds@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/pwm@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/spi@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/uart@0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/uart@1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /pinctrl@10005000/uart@2 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /ethernet@1b100000/mdio-bus/switch@0/ports has a reg or ranges property, but no unit name
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org
---
arch/arm/boot/dts/mt7623.dtsi | 4 ++--
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 29 +++++++++++++--------------
arch/arm/boot/dts/mt7623n-rfb.dtsi | 2 +-
3 files changed, 17 insertions(+), 18 deletions(-)
On 02/23/2018 11:16 AM, sean.wang@mediatek.com wrote:
quoted hunk
From: Sean Wang <sean.wang@mediatek.com>
Since those LEDs are parts of PMIC MT6323, it is reasonable to merge
those LEDs node definition back into mt6323.dtsi. This way can improve
the reusability of those nodes among different boards with the same PMIC.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Lee Jones <redacted>
---
arch/arm/boot/dts/mt6323.dtsi | 26 ++++++++++++++++++++++++-
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 28 ---------------------------
2 files changed, 25 insertions(+), 29 deletions(-)
The color of the leds are defined by the board and not by the PMIC. So as long
as you don't have any good arguments, I tend not to merge this one.
Regards,
Matthias
On Fri, 2018-03-02 at 09:40 -0600, Rob Herring wrote:
quoted
On Fri, Feb 23, 2018 at 06:16:33PM +0800, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
Since those LEDs are parts of PMIC MT6323, it is reasonable to merge
those LEDs node definition back into mt6323.dtsi. This way can improve
the reusability of those nodes among different boards with the same PMIC.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Lee Jones <redacted>
---
arch/arm/boot/dts/mt6323.dtsi | 26 ++++++++++++++++++++++++-
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 28 ---------------------------
2 files changed, 25 insertions(+), 29 deletions(-)
Changing the label potentially breaks userspace. And the fact that it is
a green LED is very much board specific. So I think the old location was
correct. You could put the parent node here and leave these child nodes
in the board specific dts file.
yes, I really made a mistake on breaking userspace with a label change.
I will keep the parent node here and then leave these child nodes into
board specific dts files. thanks for your idea!
Sorry I didn't see your email when I wrote my first comment. Yes this sounds
like the proper way to do it.
Regards,
Matthias
On 02/23/2018 11:16 AM, sean.wang@mediatek.com wrote:
From: Sean Wang <sean.wang@mediatek.com>
Both mmc devices on bananapi-r2 board should all use the fixed regulators
as their power source instead of PMIC MT6323 exports.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
On 02/23/2018 11:16 AM, sean.wang@mediatek.com wrote:
From: Sean Wang <sean.wang@mediatek.com>
On bpi-r2 board, totally there're four UARTs which we usually called
uart[0-3] helpful to extend slow-I/O devices. Among those ones, uart2 has
dedicated pin slot which is used to console log. uart[0-1] appear at the
40-pins connector and uart3 has no pinout, but just has test points (TP47
for TX and TP48 for RX, respectively) nearby uart2, but we don't enable
uart3 in the patch. The missing pinctrl is also being supplemented for
those newly added devices.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
On 02/23/2018 11:16 AM, sean.wang@mediatek.com wrote:
From: Sean Wang <sean.wang@mediatek.com>
Complement the missing clock properties cpu[1-3] should depend on.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: "Rafael J. Wysocki" <redacted>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org
On 02/23/2018 11:16 AM, sean.wang@mediatek.com wrote:
From: Sean Wang <sean.wang@mediatek.com>
The property pinctrl-names is totally superfluous. It would be good to
remove the property to keep the node neatness. There is actually
unnecessary to set up any pins for data path TRGMII between main SoC and
MT7530. Furthermore, it's more reasonable for the pin setup of control
path MDIO bus is being placed inside the node of ethernet controller.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
On 02/23/2018 11:16 AM, sean.wang@mediatek.com wrote:
From: Sean Wang <sean.wang@mediatek.com>
It should be good that no use "_" is in DT node name. Consequently,
those nodes in certain files which have an inappropriate name containing
"_" are all being replaced with "-".
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org
From: Sean Wang <sean.wang@mediatek.com> Date: 2018-03-19 02:51:14
Hi, Matthias
I'm worried you missed the patch which already got both tags Reviewed-by
from Rob and Acked-by: Viresh and thus I thought it
should be ready for your tree.
For the other patches in the same series, I will have v2 to refine them
according to these suggestions and comments in v1 and let them easy to
review.
Really thanks for your effort!
Sean
On Mon, 2018-02-26 at 09:43 +0530, Viresh Kumar wrote:
On 23-02-18, 18:16, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
It should be good that no use "_" is in examples. Consequently,
those nodes in certain files which have an inappropriate name containing
"_" are all being replaced with "-".
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: "Rafael J. Wysocki" <redacted>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-pm@vger.kernel.org
Cc: devicetree@vger.kernel.org
---
Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Hi, Matthias
I'm worried you missed the patch which already got both tags Reviewed-by
from Rob and Acked-by: Viresh and thus I thought it
should be ready for your tree.
Yes, sorry I missed this one. Fortunately it is not critical, can you please add
it to v2.
I suppose you realized that I didn't take any from 12/19 onwards, especially 14,
15 and 17, because they have many conflicts with previous patches in the series.
Sorry for the inconvenience.
Matthias
For the other patches in the same series, I will have v2 to refine them
according to these suggestions and comments in v1 and let them easy to
review.
Really thanks for your effort!
Sean
On Mon, 2018-02-26 at 09:43 +0530, Viresh Kumar wrote:
quoted
On 23-02-18, 18:16, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
It should be good that no use "_" is in examples. Consequently,
those nodes in certain files which have an inappropriate name containing
"_" are all being replaced with "-".
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: "Rafael J. Wysocki" <redacted>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-pm@vger.kernel.org
Cc: devicetree@vger.kernel.org
---
Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)