--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Add clock controller nodes for MT7622 and include header for topckgen,
infracfg, pericfg, apmixedsys, ethsys, sgmiisys, pciesys and ssusbsys
for those devices nodes to be added afterwards.
In addition, provides an oscillator node for the source of PLLs and dummy
clock for PWARP to complement missing support of clock gate for the
wrapper circuit in the driver.
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Stephen Boyd <redacted>
---
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 76 ++++++++++++++++++++++++++++++++
1 file changed, 76 insertions(+)
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
add pinctrl device nodes and rfb1 board, additionally include all pin
groups possible being used on rfb1 board and available gpio keys.
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 200 +++++++++++++++++++++++++++
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 7 +
2 files changed, 207 insertions(+)
@@ -17,11 +19,209 @@bootargs="console=ttyS0,115200n1";};+gpio-keys{+compatible="gpio-keys-polled";+poll-interval=<100>;++factory{+label="factory";+linux,code=<BTN_0>;+gpios=<&pio00>;+};++wps{+label="wps";+linux,code=<KEY_WPS_BUTTON>;+gpios=<&pio1020>;+};+};+memory{reg=<00x4000000000x3F000000>;};};+&pio{+/* eMMC is shared pin with parallel NAND */+emmc_pins_default:emmc-pins-default{+mux{+function="emmc","emmc_rst";+groups="emmc";+};+};++emmc_pins_uhs:emmc-pins-uhs{+mux{+function="emmc";+groups="emmc";+};+};++eth_pins:eth-pins{+mux{+function="eth";+groups="mdc_mdio","rgmii_via_gmac2";+};+};++i2c1_pins:i2c1-pins{+mux{+function="i2c";+groups="i2c1_0";+};+};++i2c2_pins:i2c2-pins{+mux{+function="i2c";+groups="i2c2_0";+};+};++i2s1_pins:i2s1-pins{+mux{+function="i2s";+groups="i2s_out_bclk_ws_mclk",+"i2s1_in_data",+"i2s1_out_data";+};+};++irrx_pins:irrx-pins{+mux{+function="ir";+groups="ir_1_rx";+};+};++irtx_pins:irtx-pins{+mux{+function="ir";+groups="ir_1_tx";+};+};++/* Parallel nand is shared pin with eMMC */+parallel_nand_pins:parallel-nand-pins{+mux{+function="flash";+groups="par_nand";+};+};++pcie0_pins:pcie0-pins{+mux{+groups="pcie0_pad_perst",+"pcie0_1_waken",+"pcie0_1_clkreq";+function="pcie";+};+};++pcie1_pins:pcie1-pins{+mux{+groups="pcie1_pad_perst",+"pcie1_0_waken",+"pcie1_0_clkreq";+function="pcie";+};+};++pmic_bus_pins:pmic-bus-pins{+mux{+groups="pmic_bus";+function="pmic";+};+};++pwm7_pins:pwm1-2-pins{+mux{+function="pwm";+groups="pwm_ch7_2";+};+};++wled_pins:wled-pins{+mux{+function="led";+groups="wled";+};+};++sd0_pins_default:sd0-pins-default{+mux{+function="sd";+groups="sd_0";+};+};++sd0_pins_uhs:sd0-pins-uhs{+mux{+function="sd";+groups="sd_0";+};+};++/* Serial NAND is shared pin with SPI-NOR */+serial_nand_pins:serial-nand-pins{+mux{+function="flash";+groups="snfi";+};+};++spic0_pins:spic0-pins{+mux{+function="spi";+groups="spic0_0";+};+};++spic1_pins:spic1-pins{+mux{+function="spi";+groups="spic1_0";+};+};++/* SPI-NOR is shared pin with serial NAND */+spi_nor_pins:spi-nor-pins{+mux{+function="flash";+groups="spi_nor";+};+};++/* serial NAND is shared pin with SPI-NOR */+serial_nand_pins:serial-nand-pins{+mux{+function="flash";+groups="snfi";+};+};++uart0_pins:uart0-pins{+mux{+function="uart";+groups="uart0_0_tx_rx";+};+};++uart2_pins:uart2-pins{+mux{+function="uart";+groups="uart2_1_tx_rx";+};+};++watchdog_pins:watchdog-pins{+mux{+function="watchdog";+groups="watchdog";+};+};+};+&uart0{status="okay";};
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sean Wang <sean.wang@mediatek.com>
add mmc device nodes and proper setup for used pins
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: Jimin Wang <redacted>
---
arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 106 +++++++++++++++++++++++++++
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 20 +++++
2 files changed, 126 insertions(+)
@@ -201,6 +263,18 @@function="sd";groups="sd_0";};++conf-cmd-data{+pins="I2S2_OUT","I2S4_IN","I2S3_IN",+"I2S2_IN","I2S4_OUT";+input-enable;+bias-pull-up;+};++conf-clk{+pins="I2S3_OUT";+bias-pull-down;+};};/* Serial NAND is shared pin with SPI-NOR */
From: Sean Wang <sean.wang@mediatek.com>
add nodes for the thermal controller and associated thermal zone using
CPU as the cooling device for each trip point. In addition, add a fixup
for thermal_calibration on nvmem should be 12 bytes as the minimal
requirement.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 72 +++++++++++++++++++++++++++++++-
1 file changed, 71 insertions(+), 1 deletion(-)
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Ryder Lee <ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
This patch adds SATA support fot MT7622.
Signed-off-by: Ryder Lee <ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 8 ++++++
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 40 ++++++++++++++++++++++++++++
2 files changed, 48 insertions(+)
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sean Wang <sean.wang@mediatek.com>
add nodes for NOR flash, parallel Nand flash with error correction code
support.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: RogerCC Lin <redacted>
Cc: Guochun Mao <redacted>
---
arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 21 +++++++++++++++++
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 34 ++++++++++++++++++++++++++++
2 files changed, 55 insertions(+)
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
This patch also cleans up two oscillators that provide clocks for MT7623.
Switch the uart clocks to the real ones while at it.
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Matthias Brugger <redacted>
---
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Enable pwrap and MT6380 on mt7622-rfb1 board. Also add all mt6380
regulator nodes in an alone file to allow similar boards using MT6380
able to resue the configuration.
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Mark Brown <redacted>
Cc: Matthias Brugger <redacted>
Cc: Philippe Ombredanne <pombredanne-od1rfyK75/E@public.gmane.org>
---
arch/arm64/boot/dts/mediatek/mt6380.dtsi | 86 ++++++++++++++++++++++++++++
arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 8 +++
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 12 ++++
3 files changed, 106 insertions(+)
create mode 100644 arch/arm64/boot/dts/mediatek/mt6380.dtsi
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Add clocks, regulators and opp information into cpu nodes.
In addition, the power supply for cpu nodes is deployed on
mt7622-rfb1 board.
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Viresh Kumar <redacted>
---
arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 12 +++++++
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 49 ++++++++++++++++++++++++++++
2 files changed, 61 insertions(+)
From: Sean Wang <sean.wang@mediatek.com>
All ethsys, pciesys and ssusbsys internally include reset controller, so
explicitly add back these missing cell definitions to related bindings
and examples.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Stephen Boyd <redacted>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt | 2 ++
Documentation/devicetree/bindings/arm/mediatek/mediatek,pciesys.txt | 2 ++
Documentation/devicetree/bindings/arm/mediatek/mediatek,ssusbsys.txt | 2 ++
3 files changed, 6 insertions(+)
@@ -9,6 +9,7 @@ Required Properties: - "mediatek,mt2701-ethsys", "syscon" - "mediatek,mt7622-ethsys", "syscon" - #clock-cells: Must be 1+- #reset-cells: Must be 1 The ethsys controller uses the common clk binding from Documentation/devicetree/bindings/clock/clock-bindings.txt
@@ -8,6 +8,7 @@ Required Properties: - compatible: Should be: - "mediatek,mt7622-pciesys", "syscon" - #clock-cells: Must be 1+- #reset-cells: Must be 1 The PCIESYS controller uses the common clk binding from Documentation/devicetree/bindings/clock/clock-bindings.txt
@@ -8,6 +8,7 @@ Required Properties: - compatible: Should be: - "mediatek,mt7622-ssusbsys", "syscon" - #clock-cells: Must be 1+- #reset-cells: Must be 1 The SSUSBSYS controller uses the common clk binding from Documentation/devicetree/bindings/clock/clock-bindings.txt
Sorry for not picking this earlier, but you should probably add the same clock
related properties for both cpu nodes here. Things will break if CPU1 is used by
the cpufreq core to bring the cpufreq policy online.
This can happen if cpufreq driver is a module, CPU0 is hotplugged out and then
the cpufreq driver is inserted.
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Sorry for not picking this earlier, but you should probably add the same clock
related properties for both cpu nodes here. Things will break if CPU1 is used by
the cpufreq core to bring the cpufreq policy online.
This can happen if cpufreq driver is a module, CPU0 is hotplugged out and then
the cpufreq driver is inserted.
mt7622 cpu0 does not support hotplug. do I still need to add same clock
related properties for both cpu nodes here?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Sorry for not picking this earlier, but you should probably add the same clock
related properties for both cpu nodes here. Things will break if CPU1 is used by
the cpufreq core to bring the cpufreq policy online.
This can happen if cpufreq driver is a module, CPU0 is hotplugged out and then
the cpufreq driver is inserted.
mt7622 cpu0 does not support hotplug. do I still need to add same clock
related properties for both cpu nodes here?
Normally we should always add these properties to all the CPUs, as that's the
real scenario hardware configuration wise.
But I am not sure if something else will break if you don't provide clocks in
CPU1.
@Rob @Mark: What do you suggest ?
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Sorry for not picking this earlier, but you should probably add the same clock
related properties for both cpu nodes here. Things will break if CPU1 is used by
the cpufreq core to bring the cpufreq policy online.
This can happen if cpufreq driver is a module, CPU0 is hotplugged out and then
the cpufreq driver is inserted.
mt7622 cpu0 does not support hotplug. do I still need to add same clock
related properties for both cpu nodes here?
Normally we should always add these properties to all the CPUs, as that's the
real scenario hardware configuration wise.
Agree on, I will add these missing clock properties also into the cpu1
node to reflect the hardware actually should have.
That also is devicetree wants us to do to describe the device more
closely.
But I am not sure if something else will break if you don't provide clocks in
CPU1.
@Rob @Mark: What do you suggest ?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/06/2018 10:52 AM, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote:
quoted hunk
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
All ethsys, pciesys and ssusbsys internally include reset controller, so
explicitly add back these missing cell definitions to related bindings
and examples.
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Rob Herring <redacted>
Cc: Stephen Boyd <redacted>
Reviewed-by: Rob Herring <redacted>
---
Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt | 2 ++
Documentation/devicetree/bindings/arm/mediatek/mediatek,pciesys.txt | 2 ++
Documentation/devicetree/bindings/arm/mediatek/mediatek,ssusbsys.txt | 2 ++
3 files changed, 6 insertions(+)
@@ -9,6 +9,7 @@ Required Properties: - "mediatek,mt2701-ethsys", "syscon" - "mediatek,mt7622-ethsys", "syscon" - #clock-cells: Must be 1+- #reset-cells: Must be 1 The ethsys controller uses the common clk binding from Documentation/devicetree/bindings/clock/clock-bindings.txt
The example is already fixed upstream, but I forgot the binding description,
please rebase this patch.
And please don't forget to add all clock maintainers.
Regards,
Matthias
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/06/2018 10:52 AM, sean.wang@mediatek.com wrote:
quoted hunk
From: Sean Wang <sean.wang@mediatek.com>
add pinctrl device nodes and rfb1 board, additionally include all pin
groups possible being used on rfb1 board and available gpio keys.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 200 +++++++++++++++++++++++++++
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 7 +
2 files changed, 207 insertions(+)
@@ -17,11 +19,209 @@bootargs="console=ttyS0,115200n1";};+gpio-keys{+compatible="gpio-keys-polled";+poll-interval=<100>;++factory{+label="factory";+linux,code=<BTN_0>;+gpios=<&pio00>;+};++wps{+label="wps";+linux,code=<KEY_WPS_BUTTON>;+gpios=<&pio1020>;+};+};+memory{reg=<00x4000000000x3F000000>;};};+&pio{+/* eMMC is shared pin with parallel NAND */+emmc_pins_default:emmc-pins-default{+mux{+function="emmc","emmc_rst";+groups="emmc";+};+};++emmc_pins_uhs:emmc-pins-uhs{+mux{+function="emmc";+groups="emmc";+};+};++eth_pins:eth-pins{+mux{+function="eth";+groups="mdc_mdio","rgmii_via_gmac2";+};+};++i2c1_pins:i2c1-pins{+mux{+function="i2c";+groups="i2c1_0";+};+};++i2c2_pins:i2c2-pins{+mux{+function="i2c";+groups="i2c2_0";+};+};++i2s1_pins:i2s1-pins{+mux{+function="i2s";+groups="i2s_out_bclk_ws_mclk",+"i2s1_in_data",+"i2s1_out_data";+};+};++irrx_pins:irrx-pins{+mux{+function="ir";+groups="ir_1_rx";+};+};++irtx_pins:irtx-pins{+mux{+function="ir";+groups="ir_1_tx";+};+};++/* Parallel nand is shared pin with eMMC */+parallel_nand_pins:parallel-nand-pins{+mux{+function="flash";+groups="par_nand";+};+};++pcie0_pins:pcie0-pins{+mux{+groups="pcie0_pad_perst",+"pcie0_1_waken",+"pcie0_1_clkreq";+function="pcie";+};+};++pcie1_pins:pcie1-pins{+mux{+groups="pcie1_pad_perst",+"pcie1_0_waken",+"pcie1_0_clkreq";+function="pcie";+};+};++pmic_bus_pins:pmic-bus-pins{+mux{+groups="pmic_bus";+function="pmic";+};+};
Some bikeshedding here. Can you please add function before groups, so that it is
uniform through out the file?
Thanks,
Matthias
quoted hunk
+
+ pwm7_pins: pwm1-2-pins {
+ mux {
+ function = "pwm";
+ groups = "pwm_ch7_2";
+ };
+ };
+
+ wled_pins: wled-pins {
+ mux {
+ function = "led";
+ groups = "wled";
+ };
+ };
+
+ sd0_pins_default: sd0-pins-default {
+ mux {
+ function = "sd";
+ groups = "sd_0";
+ };
+ };
+
+ sd0_pins_uhs: sd0-pins-uhs {
+ mux {
+ function = "sd";
+ groups = "sd_0";
+ };
+ };
+
+ /* Serial NAND is shared pin with SPI-NOR */
+ serial_nand_pins: serial-nand-pins {
+ mux {
+ function = "flash";
+ groups = "snfi";
+ };
+ };
+
+ spic0_pins: spic0-pins {
+ mux {
+ function = "spi";
+ groups = "spic0_0";
+ };
+ };
+
+ spic1_pins: spic1-pins {
+ mux {
+ function = "spi";
+ groups = "spic1_0";
+ };
+ };
+
+ /* SPI-NOR is shared pin with serial NAND */
+ spi_nor_pins: spi-nor-pins {
+ mux {
+ function = "flash";
+ groups = "spi_nor";
+ };
+ };
+
+ /* serial NAND is shared pin with SPI-NOR */
+ serial_nand_pins: serial-nand-pins {
+ mux {
+ function = "flash";
+ groups = "snfi";
+ };
+ };
+
+ uart0_pins: uart0-pins {
+ mux {
+ function = "uart";
+ groups = "uart0_0_tx_rx" ;
+ };
+ };
+
+ uart2_pins: uart2-pins {
+ mux {
+ function = "uart";
+ groups = "uart2_1_tx_rx" ;
+ };
+ };
+
+ watchdog_pins: watchdog-pins {
+ mux {
+ function = "watchdog";
+ groups = "watchdog";
+ };
+ };
+};
+
&uart0 {
status = "okay";
};
On 02/06/2018 10:53 AM, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote:
quoted hunk
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
add nodes for the thermal controller and associated thermal zone using
CPU as the cooling device for each trip point. In addition, add a fixup
for thermal_calibration on nvmem should be 12 bytes as the minimal
requirement.
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 72 +++++++++++++++++++++++++++++++-
1 file changed, 71 insertions(+), 1 deletion(-)
Any reason why this is not part of patch 8/16?
Regards,
Matthias
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Philippe Ombredanne <hidden> Date: 2018-02-08 14:47:32
Sean,
On Tue, Feb 6, 2018 at 10:52 AM, [off-list ref] wrote:
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Enable pwrap and MT6380 on mt7622-rfb1 board. Also add all mt6380
regulator nodes in an alone file to allow similar boards using MT6380
able to resue the configuration.
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Mark Brown <redacted>
Cc: Matthias Brugger <redacted>
Cc: Philippe Ombredanne <pombredanne-od1rfyK75/E@public.gmane.org>
Thank you for the use of SPDX licenses ids!
Acked-by: Philippe Ombredanne <pombredanne-od1rfyK75/E@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sean Wang <sean.wang@mediatek.com> Date: 2018-02-09 03:39:03
On Wed, 2018-02-07 at 11:45 +0100, Matthias Brugger wrote:
On 02/06/2018 10:52 AM, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote:
quoted
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
All ethsys, pciesys and ssusbsys internally include reset controller, so
explicitly add back these missing cell definitions to related bindings
and examples.
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Rob Herring <redacted>
Cc: Stephen Boyd <redacted>
Reviewed-by: Rob Herring <redacted>
---
Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt | 2 ++
Documentation/devicetree/bindings/arm/mediatek/mediatek,pciesys.txt | 2 ++
Documentation/devicetree/bindings/arm/mediatek/mediatek,ssusbsys.txt | 2 ++
3 files changed, 6 insertions(+)
@@ -9,6 +9,7 @@ Required Properties: - "mediatek,mt2701-ethsys", "syscon" - "mediatek,mt7622-ethsys", "syscon" - #clock-cells: Must be 1+- #reset-cells: Must be 1 The ethsys controller uses the common clk binding from Documentation/devicetree/bindings/clock/clock-bindings.txt
The example is already fixed upstream, but I forgot the binding description,
please rebase this patch.
And please don't forget to add all clock maintainers.
okay, i will do it.
Regards,
Matthias
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sean Wang <sean.wang@mediatek.com> Date: 2018-02-09 03:41:24
On Wed, 2018-02-07 at 12:31 +0100, Matthias Brugger wrote:
On 02/06/2018 10:52 AM, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote:
quoted
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
add pinctrl device nodes and rfb1 board, additionally include all pin
groups possible being used on rfb1 board and available gpio keys.
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 200 +++++++++++++++++++++++++++
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 7 +
2 files changed, 207 insertions(+)
@@ -17,11 +19,209 @@bootargs="console=ttyS0,115200n1";};+gpio-keys{+compatible="gpio-keys-polled";+poll-interval=<100>;++factory{+label="factory";+linux,code=<BTN_0>;+gpios=<&pio00>;+};++wps{+label="wps";+linux,code=<KEY_WPS_BUTTON>;+gpios=<&pio1020>;+};+};+memory{reg=<00x4000000000x3F000000>;};};+&pio{+/* eMMC is shared pin with parallel NAND */+emmc_pins_default:emmc-pins-default{+mux{+function="emmc","emmc_rst";+groups="emmc";+};+};++emmc_pins_uhs:emmc-pins-uhs{+mux{+function="emmc";+groups="emmc";+};+};++eth_pins:eth-pins{+mux{+function="eth";+groups="mdc_mdio","rgmii_via_gmac2";+};+};++i2c1_pins:i2c1-pins{+mux{+function="i2c";+groups="i2c1_0";+};+};++i2c2_pins:i2c2-pins{+mux{+function="i2c";+groups="i2c2_0";+};+};++i2s1_pins:i2s1-pins{+mux{+function="i2s";+groups="i2s_out_bclk_ws_mclk",+"i2s1_in_data",+"i2s1_out_data";+};+};++irrx_pins:irrx-pins{+mux{+function="ir";+groups="ir_1_rx";+};+};++irtx_pins:irtx-pins{+mux{+function="ir";+groups="ir_1_tx";+};+};++/* Parallel nand is shared pin with eMMC */+parallel_nand_pins:parallel-nand-pins{+mux{+function="flash";+groups="par_nand";+};+};++pcie0_pins:pcie0-pins{+mux{+groups="pcie0_pad_perst",+"pcie0_1_waken",+"pcie0_1_clkreq";+function="pcie";+};+};++pcie1_pins:pcie1-pins{+mux{+groups="pcie1_pad_perst",+"pcie1_0_waken",+"pcie1_0_clkreq";+function="pcie";+};+};++pmic_bus_pins:pmic-bus-pins{+mux{+groups="pmic_bus";+function="pmic";+};+};
Some bikeshedding here. Can you please add function before groups, so that it is
uniform through out the file?
Thanks,
Matthias
okay, will make them all aligned
quoted
+
+ pwm7_pins: pwm1-2-pins {
+ mux {
+ function = "pwm";
+ groups = "pwm_ch7_2";
+ };
+ };
+
+ wled_pins: wled-pins {
+ mux {
+ function = "led";
+ groups = "wled";
+ };
+ };
+
+ sd0_pins_default: sd0-pins-default {
+ mux {
+ function = "sd";
+ groups = "sd_0";
+ };
+ };
+
+ sd0_pins_uhs: sd0-pins-uhs {
+ mux {
+ function = "sd";
+ groups = "sd_0";
+ };
+ };
+
+ /* Serial NAND is shared pin with SPI-NOR */
+ serial_nand_pins: serial-nand-pins {
+ mux {
+ function = "flash";
+ groups = "snfi";
+ };
+ };
+
+ spic0_pins: spic0-pins {
+ mux {
+ function = "spi";
+ groups = "spic0_0";
+ };
+ };
+
+ spic1_pins: spic1-pins {
+ mux {
+ function = "spi";
+ groups = "spic1_0";
+ };
+ };
+
+ /* SPI-NOR is shared pin with serial NAND */
+ spi_nor_pins: spi-nor-pins {
+ mux {
+ function = "flash";
+ groups = "spi_nor";
+ };
+ };
+
+ /* serial NAND is shared pin with SPI-NOR */
+ serial_nand_pins: serial-nand-pins {
+ mux {
+ function = "flash";
+ groups = "snfi";
+ };
+ };
+
+ uart0_pins: uart0-pins {
+ mux {
+ function = "uart";
+ groups = "uart0_0_tx_rx" ;
+ };
+ };
+
+ uart2_pins: uart2-pins {
+ mux {
+ function = "uart";
+ groups = "uart2_1_tx_rx" ;
+ };
+ };
+
+ watchdog_pins: watchdog-pins {
+ mux {
+ function = "watchdog";
+ groups = "watchdog";
+ };
+ };
+};
+
&uart0 {
status = "okay";
};
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sean Wang <sean.wang@mediatek.com> Date: 2018-02-09 03:52:01
On Wed, 2018-02-07 at 12:43 +0100, Matthias Brugger wrote:
On 02/06/2018 10:53 AM, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
add nodes for the thermal controller and associated thermal zone using
CPU as the cooling device for each trip point. In addition, add a fixup
for thermal_calibration on nvmem should be 12 bytes as the minimal
requirement.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 72 +++++++++++++++++++++++++++++++-
1 file changed, 71 insertions(+), 1 deletion(-)
There's no strong reason wanting me to do that. patch 8 has contained a
lot of nodes and patch 16 is present just in v2. So, I felt it should be
a little bit easy that people reviews those patches if they are put into
separate patches. But, It's still fine to make them into one in the next
version.
On Wed, 2018-02-07 at 12:43 +0100, Matthias Brugger wrote:
quoted
On 02/06/2018 10:53 AM, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
add nodes for the thermal controller and associated thermal zone using
CPU as the cooling device for each trip point. In addition, add a fixup
for thermal_calibration on nvmem should be 12 bytes as the minimal
requirement.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 72 +++++++++++++++++++++++++++++++-
1 file changed, 71 insertions(+), 1 deletion(-)
There's no strong reason wanting me to do that. patch 8 has contained a
lot of nodes and patch 16 is present just in v2. So, I felt it should be
a little bit easy that people reviews those patches if they are put into
separate patches. But, It's still fine to make them into one in the next
version.
Please add it to 8/16 as this is where you define the node in the first place.
Thanks!