[PATCH] [v4.15-stable] arm64: dts: add #cooling-cells to CPU nodes

Subsystems: arm/mediatek soc support, the rest

STALE3125d REVIEWED: 2 (2M)

1 review trailer.

2 messages, 2 authors, 2018-02-23 · open the first message on its own page

[PATCH] [v4.15-stable] arm64: dts: add #cooling-cells to CPU nodes

From: Arnd Bergmann <arnd@arndb.de>
Date: 2018-02-21 16:29:19

commit acbf76ee05067c3942852019993f7beb69a0f45f upstream.

dtc complains about the lack of #coolin-cells properties for the
CPU nodes that are referred to as "cooling-device":

arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: Warning (cooling_device_property): Missing property '#cooling-cells' in node /cpus/cpu@0 or bad phandle (referred from /thermal-zones/cpu_thermal/cooling-maps/map@0:cooling-device[0])
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: Warning (cooling_device_property): Missing property '#cooling-cells' in node /cpus/cpu@100 or bad phandle (referred from /thermal-zones/cpu_thermal/cooling-maps/map@1:cooling-device[0])

Apparently this property must be '<2>' to match the binding.

Signed-off-by: Arnd Bergmann <redacted>
Tested-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Signed-off-by: Olof Johansson <redacted>
[arnd: backported to 4.15]
Signed-off-by: Arnd Bergmann <redacted>
---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index 26396ef53bde..ea407aff1251 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -81,6 +81,7 @@
 			reg = <0x000>;
 			enable-method = "psci";
 			cpu-idle-states = <&CPU_SLEEP_0>;
+			#cooling-cells = <2>;
 		};
 
 		cpu1: cpu@1 {
@@ -97,6 +98,7 @@
 			reg = <0x100>;
 			enable-method = "psci";
 			cpu-idle-states = <&CPU_SLEEP_0>;
+			#cooling-cells = <2>;
 		};
 
 		cpu3: cpu@101 {
-- 
2.9.0

Re: [PATCH] [v4.15-stable] arm64: dts: add #cooling-cells to CPU nodes

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2018-02-23 07:42:28

On Wed, Feb 21, 2018 at 05:29:19PM +0100, Arnd Bergmann wrote:
commit acbf76ee05067c3942852019993f7beb69a0f45f upstream.
Now applied, thanks.

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help