On Thu, Nov 30, 2017 at 08:25:26PM +0100, Philippe Ombredanne wrote:

On Thu, Nov 30, 2017 at 6:41 PM,  [off-list ref] wrote:
[]

quoted

diff --git a/drivers/slimbus/sched.c b/drivers/slimbus/sched.c
new file mode 100644
index 000000000000..74300f1a6898
--- /dev/null
+++ b/drivers/slimbus/sched.c

@@ -0,0 +1,128 @@
+/* Copyright (c) 2011-2016, The Linux Foundation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.

Could it make sense to use the new SPDX ids here? e.g.

quoted

+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2011-2016, The Linux Foundation

This neat and cleaner, is it?
See tglx doc posted as patches and Linus comments for a rationale on
the comment styles.

Yes please, otherwise I'll just have to write add-on patches to do just
this :)

thanks,

greg k-h