# Re: \[PATCH v7 2/2\] backlight arcxcnn add support for ArcticSand devices - From: Daniel Thompson \ - Date: 2017-03-14 16:10:02 - List: linux-devicetree - Page: https://ratatoskr.run/linux-devicetree/2017/03/4954701 - Thread: https://ratatoskr.run/linux-fbdev/2017/03/4953693/t.md ```text On 14/03/17 15:53, Brian Dodge wrote: > Hi Daniel, > > Yes checkpatch.pl was telling us this. I didn't think we had the > "authority" to modify that file. You don't really need authority to propose changes (e.g. send a patch). I guess you might attract sharp words from a maintainer if the proposed change were conspicuously reckless or extremely short sighted ("my use case is the only one that really matters") but I don't see any risk of that here. Think of it like this: if folks with @arcticsand.com mail addresses don't try to document the vendor prefix, who will? > Is it OK if we put the > vendor-prefixes.txt change in the first patch (device tree bindings) or > so you think we should have an 0003 patch for just that? Personally I'd add it as a new patch but I'd make it the *first* patch in the series. Daniel. PS Top posting *is* something that will eventually attract sharp words from some maintainers ;-) > On 03/14/2017 06:16 AM, Daniel Thompson wrote: >> On 13/03/17 18:22, Olimpiu Dejeu wrote: >>> backlight: Add support for Arctic Sand LED backlight driver chips >>> This driver provides support for the Arctic Sand arc2c0608 chip, >>> and provides a framework to support future devices. >>> Signed-off-by: Olimpiu Dejeu >> >> Please could you also submit a patch to add arc to >> ./Documentation/devicetree/bindings/vendor-prefixes.txt. >> >> checkpatch.pl should have been asking you to do since v1 but only if >> you test the patch series against a clean kernel (tools such as aiaiai >> can help with this). >> >> However, once that is attended to: >> >> Reviewed-by: Daniel Thompson >> >> >> Daniel. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ```