Re: [PATCH v3 5/6] ARM: dts: sunxi: add dtsi file for V3s SoC

2017年1月21日 04:48于 Maxime Ripard [off-list ref]写道：

On Fri, Jan 20, 2017 at 01:54:47AM +0800, Icenowy Zheng wrote: 

quoted

As we have the pinctrl and clock support for the V3s SoC, it's now to 
run a mainline Linux on it. 

So add a .dtsi file for it. 

Signed-off-by: Icenowy Zheng <redacted> 

Next time, please provide a description of what that SoC in your 
commit log. 

quoted

+ rtc: rtc@01c20400 { 
+ compatible = "allwinner,sun6i-a31-rtc"; 
+ reg = <0x01c20400 0x54>; 
+ interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>, 
+      <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>; 
+ }; 

Did you have the chance to actually test how the RTC was behaving? 

Other RTC have been pretty bad at keeping time, this is probably 
something you want to check. 

Currently no...

Applied, 
Maxime 

-- 
Maxime Ripard, Free Electrons 
Embedded Linux and Kernel engineering 
http://free-electrons.com