Re: Re: [PATCH v2 6/9] arm64: dts: allwinner: add Allwinner H5 .dtsi

From: Icenowy Zheng <hidden>
Date: 2017-01-27 16:03:27
Also in: alsa-devel, linux-gpio

2017年1月27日 23:58于 Maxime Ripard [off-list ref]写道:
On Thu, Jan 26, 2017 at 11:48:56PM +0800, Icenowy Zheng wrote: 
quoted
+ mmc@01c0f000 { 
Please use a label based syntax here too. 
quoted
+ compatible = "allwinner,sun50i-a64-mmc", 
+      "allwinner,sun5i-a13-mmc"; 
The compatibility with the A13 has never been true, and the compatible 
should be "allwinner,sun50i-h5-mmc", "allwinner,sun50i-a64-mmc". 
quoted
+ clocks = <&ccu CLK_BUS_MMC0>, <&ccu CLK_MMC0>; 
+ clock-names = "ahb", "mmc"; 
+ }; 
+ 
+ mmc@01c10000 { 
+ compatible = "allwinner,sun50i-a64-mmc", 
+      "allwinner,sun5i-a13-mmc"; 
+ clocks = <&ccu CLK_BUS_MMC1>, <&ccu CLK_MMC1>; 
+ clock-names = "ahb", "mmc"; 
+ }; 
+ 
+ mmc@01c11000 { 
+ compatible = "allwinner,sun50i-a64-mmc", 
And this is very likely to use the emmc compatible. 
quoted
+      "allwinner,sun5i-a13-mmc"; 
+ clocks = <&ccu CLK_BUS_MMC2>, <&ccu CLK_MMC2>; 
+ clock-names = "ahb", "mmc"; 
+ }; 
+ 
+ clock@01c20000 { 
+ compatible = "allwinner,sun50i-h5-ccu", 
+      "allwinner,sun8i-h3-ccu"; 
+ }; 
If it doesn't have the same clocks, it's not compatible with the H3. 
I'll drop it.

It's from the original patch from Andre.
Maxime 

-- 
Maxime Ripard, Free Electrons 
Embedded Linux and Kernel engineering 
http://free-electrons.com 

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group. 
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org 
For more options, visit https://groups.google.com/d/optout. 
-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help