Thread (20 messages) 20 messages, 3 authors, 2016-11-29

Re: [PATCH V4 07/10] PM / OPP: Separate out _generic_opp_set_rate()

From: Stephen Boyd <hidden>
Date: 2016-11-29 01:10:09
Also in: linux-pm, lkml

On 11/24, Viresh Kumar wrote:
Later patches would add support for custom opp_set_rate callbacks. This
patch separates out the code for generic opp_set_rate handler in order
to prepare for that.
s/opp_set_rate/set_opp/ twice?
Signed-off-by: Viresh Kumar <redacted>
Tested-by: Dave Gerlach <redacted>
---
Besides the naming confusion.

Reviewed-by: Stephen Boyd <redacted>
quoted hunk ↗ jump to hunk
@@ -1422,6 +1488,11 @@ int dev_pm_opp_set_regulators(struct device *dev, const char * const names[],
 
 	opp_table->regulator_count = count;
 
+	/* Allocate block only once to pass to ->set_rate() */
_generic_set_opp()? Or just set_opp when that gets introduced in
the next patch.
+	ret = _allocate_set_opp_data(opp_table);
+	if (ret)
+		goto free_regulators;
+
 	mutex_unlock(&opp_table_lock);
 	return 0;
 
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help